Skip to content

Commit 177e45d

Browse files
committed
Icon updates
1 parent c093f75 commit 177e45d

File tree

7 files changed

+26
-16
lines changed

7 files changed

+26
-16
lines changed

dev/components/form/checkbox.vue

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@
1111
<q-checkbox v-model="checked" checked-icon="sentiment very satisfied" unchecked-icon="sentiment very dissatisfied" :dark="dark" :keep-color="keepColor" />
1212
<q-checkbox v-model="checked" checked-icon="visibility" unchecked-icon="visibility_off" style="margin-left: 50px" :dark="dark" :keep-color="keepColor" />
1313

14-
<br><br>
14+
<p class="caption">Indeterminate</p>
15+
<q-checkbox v-model="indModel" :indeterminate="indeterminate" :dark="dark" :keep-color="keepColor" />
16+
17+
<p class="caption">Tests</p>
1518
<q-checkbox @change="onChange" @input="onInput" v-model="checked" :dark="dark" :keep-color="keepColor" />
1619
<br><br>
1720
<q-checkbox v-model="checked" label="Label" :dark="dark" :keep-color="keepColor" />
@@ -129,7 +132,9 @@ export default {
129132
group: ['op2'],
130133
selection: ['one', 'two', 'three'],
131134
dark: false,
132-
keepColor: false
135+
keepColor: false,
136+
indModel: false,
137+
indeterminate: true
133138
}
134139
},
135140
watch: {

icons/fontawesome.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,15 @@ export default {
3333
},
3434
checkbox: { // TODO
3535
checked: {
36-
ios: 'fa-check-circle',
36+
ios: 'fas fa-check-circle',
3737
mat: 'fas fa-check-square'
3838
},
3939
unchecked: {
40-
ios: 'fa-circle far',
40+
ios: 'far fa-circle',
4141
mat: 'far fa-square'
4242
},
4343
indeterminate: {
44-
ios: '',
44+
ios: 'fas fa-minus-circle',
4545
mat: 'fas fa-minus-square'
4646
}
4747
},
@@ -105,12 +105,12 @@ export default {
105105
last: 'fas fa-step-forward'
106106
},
107107
radio: {
108-
checked: { // TODO
109-
ios: 'fa-check',
108+
checked: {
109+
ios: 'fas fa-check',
110110
mat: 'fas fa-check-circle'
111111
},
112112
unchecked: {
113-
ios: 'fa-circle-o',
113+
ios: '',
114114
mat: 'far fa-circle'
115115
}
116116
},

icons/ionicons.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export default {
4141
mat: 'ion-android-checkbox-outline-blank'
4242
},
4343
indeterminate: {
44-
ios: '',
44+
ios: 'ion-ios-minus-outline',
4545
mat: 'ion-android-checkbox-blank'
4646
}
4747
},
@@ -106,11 +106,11 @@ export default {
106106
},
107107
radio: {
108108
checked: {
109-
ios: 'ion-ios-checkmark-empty',
109+
ios: 'ion-android-done',
110110
mat: 'ion-android-radio-button-on'
111111
},
112112
unchecked: {
113-
ios: 'ion-ios-circle-outline',
113+
ios: '',
114114
mat: 'ion-android-radio-button-off'
115115
}
116116
},

icons/material.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export default {
4141
mat: 'check_box_outline_blank'
4242
},
4343
indeterminate: {
44-
ios: '',
44+
ios: 'remove_circle_outline',
4545
mat: 'indeterminate_check_box'
4646
}
4747
},
@@ -110,7 +110,7 @@ export default {
110110
mat: 'radio_button_checked'
111111
},
112112
unchecked: {
113-
ios: 'radio_button_unchecked',
113+
ios: '',
114114
mat: 'radio_button_unchecked'
115115
}
116116
},

icons/mdi.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export default {
4141
mat: 'mdi-checkbox-blank-outline'
4242
},
4343
indeterminate: {
44-
ios: '',
44+
ios: 'mdi-minus-circle-outline',
4545
mat: 'mdi-minus-box'
4646
}
4747
},
@@ -110,7 +110,7 @@ export default {
110110
mat: 'mdi-radiobox-marked'
111111
},
112112
unchecked: {
113-
ios: 'mdi-radio-button-unchecked',
113+
ios: '',
114114
mat: 'mdi-radiobox-blank'
115115
}
116116
},

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@
104104
"webpack-merge": "^4.1.0"
105105
},
106106
"peerDependencies": {
107-
"quasar-extras": "^1.0.0",
107+
"quasar-extras": "^1.0.1",
108108
"vue": "^2.5.0"
109109
}
110110
}

src/components/icon/QIcon.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,12 @@ export default {
2121
if (!icon) {
2222
name = ''
2323
}
24+
else if (icon.startsWith('fa-')) {
25+
// Fontawesome 4
26+
name = `fa ${icon}`
27+
}
2428
else if (/^fa[s|r|l|b]{0,1} /.test(icon)) {
29+
// Fontawesome 5
2530
name = icon
2631
}
2732
else if (icon.startsWith('bt-')) {

0 commit comments

Comments
 (0)