Skip to content

Commit 16719db

Browse files
committed
fix(QDrawer): backdrop not initialized correctly due to faulty "showing" value quasarframework#5241
1 parent f19be2f commit 16719db

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

ui/src/components/layout/QDrawer.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export default Vue.extend({
8888
belowBreakpoint,
8989
showing: this.showIfAbove === true && belowBreakpoint === false
9090
? true
91-
: this.value
91+
: this.value === true
9292
}
9393
},
9494

@@ -537,12 +537,8 @@ export default Vue.extend({
537537
this.$emit('mini-state', this.isMini)
538538

539539
const fn = () => {
540-
if (this.showing === true) {
541-
this.__show(false, true)
542-
}
543-
else {
544-
this.__hide(false, true)
545-
}
540+
const action = this.showing === true ? 'show' : 'hide'
541+
this[`__${action}`](false, true)
546542
}
547543

548544
if (this.layout.width !== 0) {

0 commit comments

Comments
 (0)