Skip to content

Commit 951dddf

Browse files
committed
Changed PyJWT.default_options to options
and updated the CHANGELOG
1 parent 29f1ef9 commit 951dddf

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

jwt/api.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,15 @@ def __init__(self, algorithms=None, options=None):
2828
if not options:
2929
options = {}
3030

31-
self.default_options = {
31+
default_options = {
3232
'verify_signature': True,
3333
'verify_exp': True,
3434
'verify_nbf': True,
3535
'verify_iat': True,
3636
'verify_aud': True,
3737
}
3838

39-
self.options = self._merge_options(self.default_options, options)
39+
self.options = self._merge_options(default_options, options)
4040

4141
def register_algorithm(self, alg_id, alg_obj):
4242
"""
@@ -127,7 +127,7 @@ def decode(self, jwt, key='', verify=True, algorithms=None, options=None, **kwar
127127
payload, signing_input, header, signature = self._load(jwt)
128128

129129
if verify:
130-
merged_options = self._merge_options(override_options=options)
130+
merged_options = self._merge_options(self.options, override_options=options)
131131
if merged_options.get('verify_signature'):
132132
self._verify_signature(payload, signing_input, header, signature,
133133
key, algorithms)
@@ -256,7 +256,7 @@ def _merge_options(self, default_options=None, override_options=None):
256256
override_options = {}
257257

258258
try:
259-
merged_options = self.default_options.copy()
259+
merged_options = default_options.copy()
260260
merged_options.update(override_options)
261261
except (AttributeError, ValueError) as e:
262262
raise TypeError('options must be a dictionary: %s' % e)

tests/test_api.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,16 @@ def test_algorithms_parameter_removes_alg_from_algorithms_list(self):
7171
self.assertNotIn('none', self.jwt.get_algorithms())
7272
self.assertIn('HS256', self.jwt.get_algorithms())
7373

74-
def test_default_options(self):
75-
self.assertEqual(self.jwt.default_options, self.jwt.options)
76-
7774
def test_override_options(self):
7875
self.jwt = PyJWT(options={'verify_exp': False, 'verify_nbf': False})
79-
expected_options = self.jwt.default_options
76+
expected_options = self.jwt.options
8077
expected_options['verify_exp'] = False
8178
expected_options['verify_nbf'] = False
8279
self.assertEqual(expected_options, self.jwt.options)
8380

84-
def test_non_default_options_persist(self):
81+
def test_non_object_options_persist(self):
8582
self.jwt = PyJWT(options={'verify_iat': False, 'foobar': False})
86-
expected_options = self.jwt.default_options
83+
expected_options = self.jwt.options
8784
expected_options['verify_iat'] = False
8885
expected_options['foobar'] = False
8986
self.assertEqual(expected_options, self.jwt.options)

0 commit comments

Comments
 (0)