Skip to content

Commit 18160c4

Browse files
authored
Merge pull request jpadilla#219 from mike9005/es521_fix
Fix incorrectly named ECDSA algorithm
2 parents 01dae1c + 89f9a9d commit 18160c4

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

docs/algorithms.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ This library currently supports:
99
* HS512 - HMAC using SHA-512 hash algorithm
1010
* ES256 - ECDSA signature algorithm using SHA-256 hash algorithm
1111
* ES384 - ECDSA signature algorithm using SHA-384 hash algorithm
12-
* ES512 - ECDSA signature algorithm using SHA-512 hash algorithm
12+
* ES521 - ECDSA signature algorithm using SHA-512 hash algorithm
1313
* RS256 - RSASSA-PKCS1-v1_5 signature algorithm using SHA-256 hash algorithm
1414
* RS384 - RSASSA-PKCS1-v1_5 signature algorithm using SHA-384 hash algorithm
1515
* RS512 - RSASSA-PKCS1-v1_5 signature algorithm using SHA-512 hash algorithm

jwt/algorithms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def get_default_algorithms():
5050
'RS512': RSAAlgorithm(RSAAlgorithm.SHA512),
5151
'ES256': ECAlgorithm(ECAlgorithm.SHA256),
5252
'ES384': ECAlgorithm(ECAlgorithm.SHA384),
53-
'ES512': ECAlgorithm(ECAlgorithm.SHA512),
53+
'ES521': ECAlgorithm(ECAlgorithm.SHA512),
5454
'PS256': RSAPSSAlgorithm(RSAPSSAlgorithm.SHA256),
5555
'PS384': RSAPSSAlgorithm(RSAPSSAlgorithm.SHA384),
5656
'PS512': RSAPSSAlgorithm(RSAPSSAlgorithm.SHA512)

tests/test_api_jws.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@ def test_encode_decode_with_ecdsa_sha512(self, jws, payload):
543543
with open('tests/keys/testkey_ec', 'r') as ec_priv_file:
544544
priv_eckey = load_pem_private_key(force_bytes(ec_priv_file.read()),
545545
password=None, backend=default_backend())
546-
jws_message = jws.encode(payload, priv_eckey, algorithm='ES512')
546+
jws_message = jws.encode(payload, priv_eckey, algorithm='ES521')
547547

548548
with open('tests/keys/testkey_ec.pub', 'r') as ec_pub_file:
549549
pub_eckey = load_pem_public_key(force_bytes(ec_pub_file.read()), backend=default_backend())
@@ -552,7 +552,7 @@ def test_encode_decode_with_ecdsa_sha512(self, jws, payload):
552552
# string-formatted key
553553
with open('tests/keys/testkey_ec', 'r') as ec_priv_file:
554554
priv_eckey = ec_priv_file.read()
555-
jws_message = jws.encode(payload, priv_eckey, algorithm='ES512')
555+
jws_message = jws.encode(payload, priv_eckey, algorithm='ES521')
556556

557557
with open('tests/keys/testkey_ec.pub', 'r') as ec_pub_file:
558558
pub_eckey = ec_pub_file.read()
@@ -565,11 +565,11 @@ def test_ecdsa_related_algorithms(self, jws):
565565
if has_crypto:
566566
assert 'ES256' in jws_algorithms
567567
assert 'ES384' in jws_algorithms
568-
assert 'ES512' in jws_algorithms
568+
assert 'ES521' in jws_algorithms
569569
else:
570570
assert 'ES256' not in jws_algorithms
571571
assert 'ES384' not in jws_algorithms
572-
assert 'ES512' not in jws_algorithms
572+
assert 'ES521' not in jws_algorithms
573573

574574
def test_skip_check_signature(self, jws):
575575
token = ("eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9"

0 commit comments

Comments
 (0)