fixing bug with select *

Author: Daniel Townsend

piccolo/columns/base.py

@@ -82,7 +82,7 @@ def get_full_name(self, just_alias=False) -> str:
         column_name = self._name
 
         if not self.call_chain:
-            return f"{self.table.Meta.tablename}.{column_name}"
+            return f"{self._table.Meta.tablename}.{column_name}"
 
         column_name = (
             "$".join([i._name for i in self.call_chain])

piccolo/query/methods/select.py

@@ -80,12 +80,12 @@ def querystring(self) -> QueryString:
         joins: t.List[str] = []
 
         if len(self.selected_columns) == 0:
-            columns_str = "*"
-        else:
-            column_names: t.List[str] = [
-                c.get_full_name() for c in self.selected_columns
-            ]
-            columns_str = ", ".join(column_names)
+            self.selected_columns = self.table.Meta.columns
+
+        column_names: t.List[str] = [
+            c.get_full_name() for c in self.selected_columns
+        ]
+        columns_str = ", ".join(column_names)
 
         #######################################################################
         # JOIN

piccolo/table.py

@@ -41,11 +41,6 @@ def __new__(cls, name, bases, namespace, **kwds):
             table.Meta.tablename = _camel_to_snake(name)
 
         columns = []
-        for key, value in namespace.items():
-            if issubclass(type(value), Column):
-                columns.append(value)
-                value._name = key
-                value._table = table
 
         # In case super classes also have columns.
         if bases:
@@ -55,6 +50,15 @@ def __new__(cls, name, bases, namespace, **kwds):
                     if _columns:
                         columns = _columns + columns
 
+            if 'id' not in namespace.keys():
+                namespace['id'] = PrimaryKey()
+
+        for key, value in namespace.items():
+            if issubclass(type(value), Column):
+                columns.append(value)
+                value._name = key
+                value._table = table
+
         table.Meta.columns = columns
         table.Meta.non_default_columns = [
             i for i in columns if type(i) != PrimaryKey
@@ -176,8 +180,6 @@ def select(cls) -> Select:
 
 class Table(metaclass=TableMeta):
 
-    id = PrimaryKey()
-
     class Meta:
         tablename = None
         columns: t.List[Column] = []