testing lots of queries via connection pool

Author: dantownsend

docs/src/piccolo/query_clauses/batch.rst

@@ -8,7 +8,7 @@ You can use ``batch`` clauses with the following queries:
 * :ref:`Objects`
 * :ref:`Select`
 
-By default, a query will returns as many rows as you ask it for. The problem is
+By default, a query will return as many rows as you ask it for. The problem is
 when you have a table containing millions of rows - you might not want to
 load them all into memory at once. To get around this, you can batch the
 responses.

tests/engine/test_pool.py

@@ -1,18 +1,16 @@
 import asyncio
 
-from unittest import TestCase
-
 from ..base import DBTestCase, postgres_only
 from ..example_project.tables import Manager
 
 
 @postgres_only
 class TestPool(DBTestCase):
-    async def create_pool(self):
+    async def _create_pool(self):
         await Manager._meta.db.start_connnection_pool()
         await Manager._meta.db.close_connnection_pool()
 
-    async def make_queries(self):
+    async def _make_query(self):
         await Manager._meta.db.start_connnection_pool()
 
         await Manager(name="Bob").save().run()
@@ -21,14 +19,34 @@ async def make_queries(self):
 
         await Manager._meta.db.close_connnection_pool()
 
+    async def _make_many_queries(self):
+        await Manager._meta.db.start_connnection_pool()
+
+        await Manager(name="Bob").save().run()
+
+        async def get_data():
+            response = await Manager.select().run()
+            self.assertEqual(response, [{"id": 1, "name": "Bob"}])
+
+        await asyncio.gather(*[get_data() for _ in range(500)])
+
+        await Manager._meta.db.close_connnection_pool()
+
     def test_creation(self):
         """
         Make sure a connection pool can be created.
         """
-        asyncio.run(self.create_pool())
+        asyncio.run(self._create_pool())
 
-    def test_queries(self):
+    def test_query(self):
         """
         Make several queries using a connection pool.
         """
-        asyncio.run(self.make_queries())
+        asyncio.run(self._make_query())
+
+    def test_many_queries(self):
+        """
+        Make sure the connection pool is working correctly, and we don't
+        exceed a connection limit - queries should queue, then succeed.
+        """
+        asyncio.run(self._make_many_queries())