Skip to content

Commit dbbceca

Browse files
committed
using class property for delete
1 parent 4555388 commit dbbceca

File tree

3 files changed

+15
-12
lines changed

3 files changed

+15
-12
lines changed

piccolo/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def backwards(migration_name: str):
192192
MIGRATION_MODULES[s].backwards() # type: ignore
193193
)
194194

195-
Migration.delete().where(
195+
Migration.delete.where(
196196
Migration.name == s
197197
).run_sync()
198198
else:

piccolo/table.py

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ def __new__(cls, name, bases, namespace, **kwds):
3939
columns.append(value)
4040
value.name = key
4141

42+
# In case super classes also have columns.
4243
if bases:
4344
for base in bases:
4445
if hasattr(base, 'Meta'):
@@ -49,6 +50,17 @@ def __new__(cls, name, bases, namespace, **kwds):
4950
table.Meta.columns = columns
5051
return table
5152

53+
###########################################################################
54+
55+
@property
56+
def delete(cls) -> Delete:
57+
"""
58+
await Band.delete.where(Band.name == 'CSharps').run()
59+
"""
60+
return Delete(
61+
table=cls
62+
)
63+
5264

5365
class Table(metaclass=TableMeta):
5466

@@ -114,7 +126,7 @@ def remove(self):
114126

115127
self.id = None
116128

117-
return self.__class__.delete().where(
129+
return self.__class__.delete.where(
118130
self.__class__.id == _id
119131
)
120132

@@ -232,15 +244,6 @@ def update(cls, **columns) -> Update:
232244
base=f'UPDATE {cls.Meta.tablename} SET {columns_str}'
233245
)
234246

235-
@classmethod
236-
def delete(cls) -> Delete:
237-
"""
238-
await Band.delete().where(Band.name == 'CSharps').run()
239-
"""
240-
return Delete(
241-
table=cls
242-
)
243-
244247
@classmethod
245248
def create(cls) -> Create:
246249
"""

tests/table/test_delete.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class TestDelete(DBTestCase):
77
def test_delete(self):
88
self.insert_rows()
99

10-
Band.delete().where(
10+
Band.delete.where(
1111
Band.name == 'CSharps'
1212
).run_sync()
1313

0 commit comments

Comments
 (0)