Merge pull request piccolo-orm#20 from piccolo-orm/mypy_fixes

Mypy fixes

Author: dantownsend

.travis.yml

@@ -21,6 +21,7 @@ before_script:
   - psql -c "CREATE EXTENSION IF NOT EXISTS \"uuid-ossp\";" -d piccolo -U postgres
 script:
   - flake8 piccolo
+  - mypy piccolo
   - cd tests && ./travis.sh
 after_success:
   - cd .. && coveralls

piccolo/apps/app/commands/new.py

@@ -3,7 +3,7 @@
 import sys
 import typing as t
 
-import black
+import black  # type: ignore
 import jinja2
 
 

piccolo/apps/asgi/commands/new.py

@@ -3,8 +3,8 @@
 import shutil
 import typing as t
 
-import black
-import colorama
+import black  # type: ignore
+import colorama  # type: ignore
 from jinja2 import Environment, FileSystemLoader
 
 

piccolo/apps/migrations/commands/new.py

@@ -6,7 +6,7 @@
 import typing as t
 from types import ModuleType
 
-import black
+import black  # type: ignore
 import jinja2
 
 from .base import BaseMigrationManager

piccolo/apps/playground/commands/run.py

@@ -129,7 +129,7 @@ def run(
         Postgres port
     """
     try:
-        import IPython
+        import IPython  # type: ignore
     except ImportError:
         print(
             "Install iPython using `pip install ipython` to use this feature."
@@ -176,6 +176,6 @@ def run(
 
     populate()
 
-    from IPython.core.interactiveshell import _asyncio_runner
+    from IPython.core.interactiveshell import _asyncio_runner  # type: ignore
 
     IPython.embed(using=_asyncio_runner)

piccolo/apps/project/commands/new.py

@@ -2,7 +2,7 @@
 import os
 import sys
 
-import black
+import black  # type: ignore
 import jinja2
 
 

piccolo/apps/shell/commands/run.py

@@ -7,7 +7,7 @@
 
 def start_ipython_shell(**tables: t.Dict[str, t.Type[Table]]):
     try:
-        import IPython
+        import IPython  # type: ignore
     except ImportError:
         print(
             "Install iPython using `pip install ipython` to use this feature."
@@ -19,7 +19,7 @@ def start_ipython_shell(**tables: t.Dict[str, t.Type[Table]]):
         if table_class_name not in existing_global_names:
             globals()[table_class_name] = table_class
 
-    from IPython.core.interactiveshell import _asyncio_runner
+    from IPython.core.interactiveshell import _asyncio_runner  # type: ignore
 
     IPython.embed(using=_asyncio_runner)
 

piccolo/columns/defaults/timestamp.py

@@ -90,7 +90,7 @@ def python(self):
         return self.datetime
 
     @classmethod
-    def from_datetime(cls, instance: datetime.datetime):
+    def from_datetime(cls, instance: datetime.datetime):  # type: ignore
         return cls(
             year=instance.year,
             month=instance.month,

piccolo/conf/apps.py

@@ -172,6 +172,10 @@ def get_table_classes(self, app_name: str) -> t.List[t.Type[Table]]:
         """
         Returns each Table subclass defined in the given app if it exists.
         Otherwise raises a ValueError.
+
+        :raises ValueError:
+            If an AppConfig can't be found for the given app_name.
+
         """
         app_config = self.get_app_config(app_name=app_name)
         if not app_config:
@@ -186,9 +190,12 @@ def get_table_with_name(
         Otherwise raises a ValueError.
         """
         app_config = self.get_app_config(app_name=app_name)
-        return app_config.get_table_with_name(
-            table_class_name=table_class_name
-        )
+        if app_config is None:
+            raise ValueError(f"Can't find an app_config for {app_name}")
+        else:
+            return app_config.get_table_with_name(
+                table_class_name=table_class_name
+            )
 
 
 class PiccoloConfModule(ModuleType):
@@ -270,10 +277,8 @@ def get_piccolo_conf_module(
         if not module_name:
             module_name = DEFAULT_MODULE_NAME
 
-        module: t.Optional[PiccoloConfModule] = None
-
         try:
-            module = import_module(module_name)
+            module = t.cast(PiccoloConfModule, import_module(module_name))
         except ModuleNotFoundError:
             if self.diagnose:
                 colored_warning(
@@ -284,8 +289,9 @@ def get_piccolo_conf_module(
                     level=Level.high,
                 )
                 print(traceback.format_exc())
-
-        return module
+            return None
+        else:
+            return module
 
     def get_app_registry(self) -> AppRegistry:
         """

piccolo/engine/postgres.py

@@ -6,11 +6,11 @@
 import typing as t
 import warnings
 
-import asyncpg
-from asyncpg.connection import Connection
-from asyncpg.cursor import Cursor
-from asyncpg.exceptions import InsufficientPrivilegeError
-from asyncpg.pool import Pool
+import asyncpg  # type: ignore
+from asyncpg.connection import Connection  # type: ignore
+from asyncpg.cursor import Cursor  # type: ignore
+from asyncpg.exceptions import InsufficientPrivilegeError  # type: ignore
+from asyncpg.pool import Pool  # type: ignore
 
 from piccolo.engine.base import Batch, Engine
 from piccolo.engine.exceptions import TransactionError