use tempfile.gettempdir instead of hardcoded tmp

This means unit tests will work on non-Unix systems, and is just generally more correct.

Author: dantownsend

tests/apps/app/commands/test_new.py

@@ -1,5 +1,6 @@
 import os
 import shutil
+import tempfile
 from unittest import TestCase
 
 from piccolo.apps.app.commands.new import new, module_exists
@@ -13,7 +14,7 @@ def test_module_exists(self):
 
 class TestNewApp(TestCase):
     def test_new(self):
-        root = "/tmp"
+        root = tempfile.gettempdir()
         app_name = "my_app"
 
         app_path = os.path.join(root, app_name)
@@ -30,7 +31,7 @@ def test_new_with_clashing_name(self):
         Test trying to create an app with the same name as a builtin Python
         package - it shouldn't be allowed.
         """
-        root = "/tmp"
+        root = tempfile.gettempdir()
         app_name = "sys"
 
         with self.assertRaises(SystemExit) as context:

tests/apps/asgi/commands/test_new.py

@@ -1,5 +1,6 @@
 import os
 import shutil
+import tempfile
 from unittest import TestCase
 from unittest.mock import patch
 
@@ -15,7 +16,7 @@ class TestNewApp(TestCase):
         "piccolo.apps.asgi.commands.new.get_server", return_value=SERVERS[0],
     )
     def test_new(self, *args, **kwargs):
-        root = "/tmp/asgi_app"
+        root = os.path.join(tempfile.gettempdir(), "asgi_app")
 
         if os.path.exists(root):
             shutil.rmtree(root)

tests/apps/migrations/commands/test_new.py

@@ -1,5 +1,6 @@
 import os
 import shutil
+import tempfile
 from unittest import TestCase
 from unittest.mock import call, patch, MagicMock
 
@@ -20,8 +21,9 @@ def test_create_new_migration(self):
         """
         Create a manual migration (i.e. non-auto).
         """
-        migration_folder = "/tmp/piccolo_migrations/"
-
+        migration_folder = os.path.join(
+            tempfile.gettempdir(), "piccolo_migrations"
+        )
         if os.path.exists(migration_folder):
             shutil.rmtree(migration_folder)
 

tests/apps/project/commands/test_new.py

@@ -1,14 +1,15 @@
 import os
 from unittest import TestCase
+import tempfile
 
 from piccolo.apps.project.commands.new import new
 
 
 class TestNewProject(TestCase):
     def test_new(self):
-        root = "/tmp"
+        root = tempfile.gettempdir()
 
-        file_path = "/tmp/piccolo_conf.py"
+        file_path = os.path.join(root, "piccolo_conf.py")
 
         if os.path.exists(file_path):
             os.unlink(file_path)