add tests for Timestamp columns in migrations

Author: dantownsend

piccolo/apps/migrations/commands/new.py

@@ -83,6 +83,10 @@ def _generate_migration_meta(app_config: AppConfig) -> NewMigrationMeta:
     )
 
 
+class NoChanges(Exception):
+    pass
+
+
 async def _create_new_migration(
     app_config: AppConfig, auto=False
 ) -> NewMigrationMeta:
@@ -108,8 +112,7 @@ async def _create_new_migration(
         )
 
         if sum([len(i.statements) for i in alter_statements]) == 0:
-            print("No changes detected - exiting.")
-            sys.exit(0)
+            raise NoChanges()
 
         file_contents = render_template(
             migration_id=meta.migration_id,
@@ -193,4 +196,7 @@ async def new(app_name: str, auto: bool = False):
     app_config = Finder().get_app_config(app_name=app_name)
 
     _create_migrations_folder(app_config.migrations_folder_path)
-    await _create_new_migration(app_config=app_config, auto=auto)
+    try:
+        await _create_new_migration(app_config=app_config, auto=auto)
+    except NoChanges:
+        print("No changes detected - exiting.")

piccolo/columns/base.py

@@ -540,7 +540,7 @@ def get_sql_value(self, value: t.Any) -> t.Any:
         elif isinstance(value, bool):
             output = str(value).lower()
         elif isinstance(value, datetime.datetime):
-            output = f"'{value.isoformat().replace('T', '')}'"
+            output = f"'{value.isoformat().replace('T', ' ')}'"
         elif isinstance(value, bytes):
             output = f"'{value.hex()}'"
         elif isinstance(value, uuid.UUID):

tests/apps/migrations/auto/integration/test_migrations.py

@@ -1,4 +1,5 @@
 from __future__ import annotations
+import datetime
 import os
 import shutil
 import tempfile
@@ -14,6 +15,7 @@
     Integer,
     SmallInt,
     Text,
+    Timestamp,
     UUID,
     Varchar,
 )
@@ -43,6 +45,10 @@ def uuid_default():
     return uuid.uuid4()
 
 
+def datetime_default():
+    return datetime.datetime.now()
+
+
 @postgres_only
 class TestMigrations(TestCase):
     def tearDown(self):
@@ -198,3 +204,22 @@ def test_uuid_column(self):
                 ]
             ]
         )
+
+    def test_timestamp_column(self):
+        self._test_migrations(
+            table_classes=[
+                self.table(column)
+                for column in [
+                    Timestamp(),
+                    Timestamp(
+                        default=datetime.datetime(year=2021, month=1, day=1)
+                    ),
+                    Timestamp(default=datetime.datetime.now),
+                    Timestamp(default=datetime_default),
+                    Timestamp(null=True, default=None),
+                    Timestamp(null=False),
+                    Timestamp(index=True),
+                    Timestamp(index=False),
+                ]
+            ]
+        )