Skip to content

Commit b6bc76e

Browse files
committed
replacing asyncio.run with run_sync
1 parent 0d02fc1 commit b6bc76e

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

piccolo/apps/migrations/commands/backwards.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import asyncio
2-
31
from piccolo.apps.migrations.auto import MigrationManager
42
from piccolo.apps.migrations.tables import Migration
3+
from piccolo.utils.sync import run_sync
54
from .base import BaseMigrationManager
65

76

@@ -69,12 +68,10 @@ def run(self):
6968
for migration_id in reversed_migration_ids:
7069
print(f"Reversing {migration_id}")
7170
migration_module = migration_modules[migration_id]
72-
response = asyncio.run(
73-
migration_module.forwards()
74-
) # type: ignore
71+
response = run_sync(migration_module.forwards())
7572

7673
if isinstance(response, MigrationManager):
77-
asyncio.run(response.run_backwards())
74+
run_sync(response.run_backwards())
7875

7976
Migration.delete().where(
8077
Migration.name == migration_id

piccolo/apps/migrations/commands/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
from __future__ import annotations
2-
import asyncio
32
import importlib
43
import os
54
import sys
@@ -13,6 +12,7 @@
1312
from piccolo.apps.migrations.auto.diffable_table import DiffableTable
1413
from piccolo.apps.migrations.auto.schema_snapshot import SchemaSnapshot
1514
from piccolo.apps.migrations.tables import Migration
15+
from piccolo.utils.sync import run_sync
1616

1717

1818
class BaseMigrationManager(Finder):
@@ -85,7 +85,7 @@ def get_migration_managers(
8585
] = self.get_migration_modules(migrations_folder)
8686

8787
for _, migration_module in migration_modules.items():
88-
response = asyncio.run(migration_module.forwards())
88+
response = run_sync(migration_module.forwards())
8989
if isinstance(response, MigrationManager):
9090
if max_migration_id:
9191
if response.migration_id == max_migration_id:

piccolo/apps/migrations/commands/forwards.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
from __future__ import annotations
2-
import asyncio
32
import sys
43
import typing as t
54

@@ -8,6 +7,7 @@
87
from piccolo.apps.migrations.tables import Migration
98
from piccolo.apps.migrations.auto import MigrationManager
109
from piccolo.conf.apps import MigrationModule
10+
from piccolo.utils.sync import run_sync
1111

1212

1313
class ForwardsMigrationManager(BaseMigrationManager):
@@ -60,10 +60,10 @@ def run_migrations(self, app_config: AppConfig) -> None:
6060
print(f"Faked {_id}")
6161
else:
6262
migration_module = migration_modules[_id]
63-
response = asyncio.run(migration_module.forwards())
63+
response = run_sync(migration_module.forwards())
6464

6565
if isinstance(response, MigrationManager):
66-
asyncio.run(response.run())
66+
run_sync(response.run())
6767

6868
print(f"Ran {_id}")
6969

0 commit comments

Comments
 (0)