the ForeignKey references argument wil now extract the module path from a string

Author: dantownsend

piccolo/columns/column_types.py

@@ -960,6 +960,9 @@ class Band(Table):
                        table_class_name="Manager",
                        module_path="some_module.tables",
                     )
+                    # Alternatively, Piccolo will interpret this string as
+                    # the same as above:
+                    # references="some_module.tables.Manager"
                 )
 
     :param on_delete:

piccolo/table.py

@@ -199,8 +199,17 @@ def __init_subclass__(
                 if references == "self":
                     references = cls
                 else:
+                    if "." in references:
+                        module_path, table_class_name = references.rsplit(
+                            ".", maxsplit=1
+                        )
+                    else:
+                        table_class_name = references
+                        module_path = cls.__module__
+
                     references = LazyTableReference(
-                        table_class_name=references, module_path=cls.__module__
+                        table_class_name=table_class_name,
+                        module_path=module_path,
                     )
 
             is_lazy = isinstance(references, LazyTableReference)

tests/columns/test_foreignkey.py

@@ -27,6 +27,10 @@ class Band3(Table):
     )
 
 
+class Band4(Table):
+    manager = ForeignKey(references="tests.columns.test_foreignkey.Manager")
+
+
 class TestForeignKeySelf(TestCase):
     """
     Test that ForeignKey columns can be created with references to the parent
@@ -68,15 +72,21 @@ class TestForeignKeyString(TestCase):
 
     def setUp(self):
         Manager.create_table().run_sync()
-        Band2.create_table().run_sync()
 
     def test_foreign_key_string(self):
+        Band2.create_table().run_sync()
         self.assertEqual(
             Band2.manager._foreign_key_meta.resolved_references, Manager
         )
+        Band2.alter().drop_table().run_sync()
+
+        Band4.create_table().run_sync()
+        self.assertEqual(
+            Band4.manager._foreign_key_meta.resolved_references, Manager
+        )
+        Band4.alter().drop_table().run_sync()
 
     def tearDown(self):
-        Band2.alter().drop_table().run_sync()
         Manager.alter().drop_table().run_sync()
 
 
@@ -86,11 +96,12 @@ def test_foreign_key_references(self):
         Make sure foreign key references are stored correctly on the table
         which is the target of the ForeignKey.
         """
-        self.assertEqual(len(Manager._meta.foreign_key_references), 4)
+        self.assertEqual(len(Manager._meta.foreign_key_references), 5)
 
         self.assertTrue(Band1.manager in Manager._meta.foreign_key_references)
         self.assertTrue(Band2.manager in Manager._meta.foreign_key_references)
         self.assertTrue(Band3.manager in Manager._meta.foreign_key_references)
+        self.assertTrue(Band4.manager in Manager._meta.foreign_key_references)
         self.assertTrue(
             Manager.manager in Manager._meta.foreign_key_references
         )
@@ -118,6 +129,7 @@ def test_attribute_access(self):
         self.assertTrue(isinstance(Band1.manager.name, Varchar))
         self.assertTrue(isinstance(Band2.manager.name, Varchar))
         self.assertTrue(isinstance(Band3.manager.name, Varchar))
+        self.assertTrue(isinstance(Band4.manager.name, Varchar))
 
     def test_recursion_limit(self):
         """