added tests for Date columns in migrations

Author: dantownsend

piccolo/apps/migrations/auto/serialisation.py

@@ -322,6 +322,7 @@ def serialise_params(params: t.Dict[str, t.Any]) -> SerialisedParams:
             )
             continue
 
+        # Plain class type
         if inspect.isclass(value) and not issubclass(value, Enum):
             params[key] = SerialisedCallable(callable_=value)
             extra_imports.append(

piccolo/columns/base.py

@@ -541,6 +541,8 @@ def get_sql_value(self, value: t.Any) -> t.Any:
             output = str(value).lower()
         elif isinstance(value, datetime.datetime):
             output = f"'{value.isoformat().replace('T', ' ')}'"
+        elif isinstance(value, datetime.date):
+            output = f"'{value.isoformat()}'"
         elif isinstance(value, datetime.time):
             output = f"'{value.isoformat()}'"
         elif isinstance(value, bytes):

piccolo/columns/column_types.py

@@ -668,6 +668,9 @@ def __init__(self, default: DateArg = DateNow(), **kwargs) -> None:
         if isinstance(default, date):
             default = DateCustom.from_date(default)
 
+        if default == date.today:
+            default = DateNow()
+
         self.default = default
         kwargs.update({"default": default})
         super().__init__(**kwargs)

piccolo/columns/defaults/date.py

@@ -50,11 +50,11 @@ def __init__(
 
     @property
     def postgres(self):
-        return self.date.isostring()
+        return f"'{self.date.isoformat()}'"
 
     @property
     def sqlite(self):
-        return self.date.isostring()
+        return f"'{self.date.isoformat()}'"
 
     def python(self):
         return self.date

tests/apps/migrations/auto/integration/test_migrations.py

@@ -12,6 +12,7 @@
 from piccolo.conf.apps import AppConfig
 from piccolo.columns.column_types import (
     BigInt,
+    Date,
     Integer,
     SmallInt,
     Text,
@@ -54,6 +55,10 @@ def time_default():
     return datetime.datetime.now().time()
 
 
+def date_default():
+    return datetime.datetime.now().date()
+
+
 @postgres_only
 class TestMigrations(TestCase):
     def tearDown(self):
@@ -245,3 +250,20 @@ def test_time_column(self):
                 ]
             ]
         )
+
+    def test_date_column(self):
+        self._test_migrations(
+            table_classes=[
+                self.table(column)
+                for column in [
+                    Date(),
+                    Date(default=datetime.date(year=2021, month=1, day=1)),
+                    Date(default=datetime.date.today),
+                    Date(default=date_default),
+                    Date(null=True, default=None),
+                    Date(null=False),
+                    Date(index=True),
+                    Date(index=False),
+                ]
+            ]
+        )