added test for piccolo asgi new

Author: dantownsend

piccolo/apps/asgi/commands/new.py

@@ -1,11 +1,11 @@
 from __future__ import annotations
-import colorama
-from jinja2 import Environment, FileSystemLoader
 import os
 import shutil
 import typing as t
 
 import black
+import colorama
+from jinja2 import Environment, FileSystemLoader
 
 
 TEMPLATE_DIR = os.path.join(os.path.dirname(__file__), "templates/starlette/")
@@ -23,29 +23,38 @@ def get_options_string(options: t.List[str]):
     )
 
 
-def new():
-    """
-    Create a basic ASGI app, including Piccolo, routing, and an admin.
-    """
-    tree = os.walk(TEMPLATE_DIR)
-
+def get_routing_framework() -> str:
     print_instruction("Which routing framework?")
     router = input(f"{get_options_string(ROUTERS)}\n") or 0
+    return ROUTERS[int(router)]
 
+
+def get_server() -> str:
     print_instruction("Which server?")
     server = input(f"{get_options_string(SERVERS)}\n") or 0
+    return SERVERS[int(server)]
+
+
+def new(root: str = ""):
+    """
+    Create a basic ASGI app, including Piccolo, routing, and an admin.
+
+    :param root:
+        Where to create the app e.g. /my/folder. By default it creates the
+        app in the current directory.
+
+    """
+    tree = os.walk(TEMPLATE_DIR)
 
     template_context = {
-        "server": SERVERS[int(server)],
-        "router": ROUTERS[int(router)],
+        "router": get_routing_framework(),
+        "server": get_server(),
     }
 
     for directory in tree:
         dir_path, sub_dir_names, file_names = directory  # type: ignore
 
-        output_dir_path = os.path.join(
-            os.getcwd(), dir_path.split(TEMPLATE_DIR)[-1]
-        )
+        output_dir_path = os.path.join(root, dir_path.split(TEMPLATE_DIR)[-1])
 
         if not os.path.exists(output_dir_path):
             folder_name = output_dir_path.split("/")[-1]

piccolo/apps/asgi/commands/templates/starlette/home/piccolo_migrations/README.md

@@ -1 +1 @@
-Add migrations using `piccolo migrations new blog --auto`.
+Add migrations using `piccolo migrations new home --auto`.

tests/apps/asgi/__init__.py

@@ -0,0 +1,26 @@
+import os
+import shutil
+from unittest import TestCase
+from unittest.mock import patch
+
+from piccolo.apps.asgi.commands.new import new, SERVERS, ROUTERS
+
+
+class TestNewApp(TestCase):
+    @patch(
+        "piccolo.apps.asgi.commands.new.get_routing_framework",
+        return_value=ROUTERS[0],
+    )
+    @patch(
+        "piccolo.apps.asgi.commands.new.get_server", return_value=SERVERS[0],
+    )
+    def test_new(self, *args, **kwargs):
+        root = "/tmp/asgi_app"
+
+        if os.path.exists(root):
+            shutil.rmtree(root)
+
+        os.mkdir(root)
+        new(root=root)
+
+        self.assertTrue(os.path.exists(os.path.join(root, "app.py")))