frozen fixes

 * Needed to copy OutputDelegate and LimitDelegate
 * Also freezing QueryString.compile_string for extra performance

Author: dantownsend

piccolo/query/base.py

@@ -214,10 +214,23 @@ async def top_bands(self, request):
         limit, output etc).
 
         """
+        querystrings = self.querystrings
+        for querystring in querystrings:
+            querystring.freeze(engine_type=self.engine_type)
+
         # Copy the query, so we don't store any references to the original.
         query = self.__class__(
             table=self.table, frozen_querystrings=self.querystrings
         )
+
+        if hasattr(self, "limit_delegate"):
+            # Needed for `response_handler`
+            query.limit_delegate = self.limit_delegate.copy()  # type: ignore
+
+        if hasattr(self, "output_delegate"):
+            # Needed for `_process_results`
+            query.output_delegate = self.output_delegate.copy()  # type: ignore
+
         return FrozenQuery(query=query)
 
     ###########################################################################

piccolo/query/methods/alter.py

@@ -293,8 +293,8 @@ class Alter(Query):
         "_set_unique",
     )
 
-    def __init__(self, table: t.Type[Table]):
-        super().__init__(table)
+    def __init__(self, table: t.Type[Table], **kwargs):
+        super().__init__(table, **kwargs)
         self._add_foreign_key_constraint: t.List[AddForeignKeyConstraint] = []
         self._add: t.List[AddColumn] = []
         self._drop_contraint: t.List[DropConstraint] = []

piccolo/query/methods/count.py

@@ -15,8 +15,8 @@
 class Count(Query):
     __slots__ = ("where_delegate",)
 
-    def __init__(self, table: t.Type[Table]):
-        super().__init__(table)
+    def __init__(self, table: t.Type[Table], **kwargs):
+        super().__init__(table, **kwargs)
         self.where_delegate = WhereDelegate()
 
     def where(self, where: Combinable) -> Count:

piccolo/query/methods/create.py

@@ -21,8 +21,9 @@ def __init__(
         table: t.Type[Table],
         if_not_exists: bool = False,
         only_default_columns: bool = False,
+        **kwargs,
     ):
-        super().__init__(table)
+        super().__init__(table, **kwargs)
         self.if_not_exists = if_not_exists
         self.only_default_columns = only_default_columns
 

piccolo/query/methods/create_index.py

@@ -17,11 +17,12 @@ def __init__(
         columns: t.List[t.Union[Column, str]],
         method: IndexMethod = IndexMethod.btree,
         if_not_exists: bool = False,
+        **kwargs,
     ):
         self.columns = columns
         self.method = method
         self.if_not_exists = if_not_exists
-        super().__init__(table)
+        super().__init__(table, **kwargs)
 
     @property
     def column_names(self) -> t.List[str]:

piccolo/query/methods/delete.py

@@ -18,8 +18,8 @@ class Delete(Query):
 
     __slots__ = ("force", "where_delegate")
 
-    def __init__(self, table: t.Type[Table], force: bool = False):
-        super().__init__(table)
+    def __init__(self, table: t.Type[Table], force: bool = False, **kwargs):
+        super().__init__(table, **kwargs)
         self.force = force
         self.where_delegate = WhereDelegate()
 

piccolo/query/methods/drop_index.py

@@ -15,10 +15,11 @@ def __init__(
         table: t.Type[Table],
         columns: t.List[t.Union[Column, str]],
         if_exists: bool = True,
+        **kwargs,
     ):
         self.columns = columns
-        self.if_exists = True
-        super().__init__(table)
+        self.if_exists = if_exists
+        super().__init__(table, **kwargs)
 
     @property
     def column_names(self) -> t.List[str]:

piccolo/query/methods/exists.py

@@ -16,8 +16,8 @@
 class Exists(Query):
     __slots__ = ("where_delegate",)
 
-    def __init__(self, table: t.Type[Table]):
-        super().__init__(table)
+    def __init__(self, table: t.Type[Table], **kwargs):
+        super().__init__(table, **kwargs)
         self.where_delegate = WhereDelegate()
 
     def where(self, where: Combinable) -> Exists:

piccolo/query/methods/insert.py

@@ -14,8 +14,8 @@
 class Insert(Query):
     __slots__ = ("add_delegate",)
 
-    def __init__(self, table: t.Type[Table], *instances: Table):
-        super().__init__(table)
+    def __init__(self, table: t.Type[Table], *instances: Table, **kwargs):
+        super().__init__(table, **kwargs)
         self.add_delegate = AddDelegate()
         self.add(*instances)
 

piccolo/query/methods/objects.py

@@ -35,8 +35,8 @@ class Objects(Query):
         "where_delegate",
     )
 
-    def __init__(self, table: t.Type[Table]):
-        super().__init__(table)
+    def __init__(self, table: t.Type[Table], **kwargs):
+        super().__init__(table, **kwargs)
         self.limit_delegate = LimitDelegate()
         self.offset_delegate = OffsetDelegate()
         self.order_by_delegate = OrderByDelegate()