fixing primary key defaults for postgres

Author: Daniel Townsend

piccolo/columns/column_types.py

@@ -34,17 +34,24 @@ def __init__(self, **kwargs) -> None:
 DEFAULT = Unquoted('DEFAULT')
 NULL = Unquoted('null')
 
+
 class PrimaryKey(Column):
     # Was column_type = 'SERIAL' for Postgres
     column_type = 'INTEGER'
 
+    def default(self, engine_type: str = 'postgres'):
+        if engine_type == 'postgres':
+            return DEFAULT
+        elif engine_type == 'sqlite':
+            return NULL
+        else:
+            raise Exception('Unrecognized engine type')
+
     def __init__(self, **kwargs) -> None:
         kwargs.update({
             'primary': True,
             'key': True
         })
-        # self.default = DEFAULT for Postgres
-        self.default = NULL
         super().__init__(**kwargs)
 
 

piccolo/table.py

@@ -199,7 +199,9 @@ def __init__(self, **kwargs):
                     # Can't use inspect - can't tell that datetime.datetime.now
                     # is a callable.
                     is_callable = hasattr(column.default, '__call__')
-                    value = column.default() if is_callable else column.default
+                    value = column.default(
+                        engine_type=self.Meta.db.engine_type
+                    ) if is_callable else column.default
                 else:
                     if not column.null:
                         raise ValueError(f"{column._name} wasn't provided")

tests/test_alter.py

@@ -16,6 +16,8 @@ def test_rename(self):
 
         rename_query.run_sync()
 
+        # The problem now is select * has changed
+        # Need to use a raw select query instead ...
         select_query = Band.select
         response = select_query.run_sync()