turning more query methods into properties

Author: dantownsend

.gitignore

@@ -9,3 +9,4 @@ build/
 piccolo.egg-info/
 build/
 dist/
+piccolo.sqlite

piccolo/columns/column_types.py

@@ -98,7 +98,7 @@ class ForeignKey(Integer):
     To change the manager:
 
         some_band.manager = some_manager_id
-        some_band.save()
+        some_band.save
 
     Or:
         some_band.set_related_object('manager', some_manager)

piccolo/commands/playground.py

@@ -68,37 +68,37 @@ def populate():
             print(e)
 
     guido = Manager(name="Guido")
-    guido.save().run_sync()
+    guido.save.run_sync()
 
     pythonistas = Band(
         name="Pythonistas",
         manager=guido.id,
         popularity=1000
     )
-    pythonistas.save().run_sync()
+    pythonistas.save.run_sync()
 
     graydon = Manager(name="Graydon")
-    graydon.save().run_sync()
+    graydon.save.run_sync()
 
     rustaceans = Band(
         name="Rustaceans",
         manager=graydon.id,
         popularity=500
     )
-    rustaceans.save().run_sync()
+    rustaceans.save.run_sync()
 
     venue = Venue(
         name="Amazing Venue",
         capacity=5000
     )
-    venue.save().run_sync()
+    venue.save.run_sync()
 
     concert = Concert(
         band_1=pythonistas.id,
         band_2=rustaceans.id,
         venue=venue.id
     )
-    concert.save().run_sync()
+    concert.save.run_sync()
 
 
 @click.command(name="playground")

piccolo/table.py

@@ -227,6 +227,7 @@ def __init__(self, **kwargs):
         if unrecognized:
             raise ValueError(f'Unrecognized columns - {unrecognized}')
 
+    @property
     def save(self):
         """
         A proxy to an insert or update query.
@@ -248,6 +249,7 @@ def save(self):
         else:
             return cls.insert().add(self)
 
+    @property
     def remove(self):
         """
         A proxy to a delete query.

tests/extensions/test_user.py

@@ -54,7 +54,7 @@ def test_login(self):
             username=username,
             password=password,
             email=email
-        ).save()
+        ).save
 
         save_query.run_sync()
 

tests/table/instance/test_delete.py

@@ -16,8 +16,8 @@ def test_delete(self):
             name='Maz'
         )
 
-        manager.save().run_sync()
-        manager.remove().run_sync()
+        manager.save.run_sync()
+        manager.remove.run_sync()
 
         # how can I implement 'flat=True'
         # Band.select.columns(Band.name).output(as_list=True).run_sync()

tests/table/instance/test_get_related.py

@@ -23,14 +23,14 @@ def test_get_related(self):
         manager = Manager(
             name="Guido"
         )
-        manager.save().run_sync()
+        manager.save.run_sync()
 
         band = Band(
             name='Pythonistas',
             manager=manager.id,
             popularity=100
         )
-        band.save().run_sync()
+        band.save.run_sync()
 
         _manager = band.get_related('manager').run_sync()
 

tests/table/instance/test_save.py

@@ -19,7 +19,7 @@ def test_save_new(self):
             name='Maz',
         )
 
-        query = manager.save()
+        query = manager.save
         print(query)
         self.assertTrue('INSERT' in query.__str__())
 
@@ -31,7 +31,7 @@ def test_save_new(self):
         self.assertTrue('Maz' in names)
 
         manager.name = 'Maz2'
-        query = manager.save()
+        query = manager.save
         print(query)
         self.assertTrue('UPDATE' in query.__str__())
 

tests/table/test_join.py

@@ -33,27 +33,27 @@ def tearDown(self):
 
     def test_join(self):
         manager_1 = Manager(name="Guido")
-        manager_1.save().run_sync()
+        manager_1.save.run_sync()
 
         band_1 = Band(name="Pythonistas", manager=manager_1.id)
-        band_1.save().run_sync()
+        band_1.save.run_sync()
 
         manager_2 = Manager(name="Graydon")
-        manager_2.save().run_sync()
+        manager_2.save.run_sync()
 
         band_2 = Band(name="Rustaceans", manager=manager_2.id)
-        band_2.save().run_sync()
+        band_2.save.run_sync()
 
         venue = Venue(name="Grand Central")
-        venue.save().run_sync()
+        venue.save.run_sync()
 
         # TODO - make sure you can also do:
         # band_1=Pythonistas
         save_query = Concert(
             band_1=band_1.id,
             band_2=band_2.id,
             venue=venue.id
-        ).save()
+        ).save
         save_query.run_sync()
 
         select_query = Concert.select.columns(

tests/table/test_objects.py

@@ -18,7 +18,7 @@ def test_get_all(self):
 
         # Now try changing the value and saving it.
         instance.name = 'Rustaceans'
-        save_query = instance.save()
+        save_query = instance.save
         save_query.run_sync()
 
         self.assertTrue(