fixing a bug in the fluent interface, when accessing the id column

dantownsend · dantownsend · commit 21438fdcfe3a · 2021-06-25T14:01:29.000+01:00
If accessing `Concert.band_1.manager.id`, an attribute error would be raised, because `id` doesn't exist.
diff --git a/piccolo/columns/column_types.py b/piccolo/columns/column_types.py
@@ -1199,8 +1199,6 @@ def __getattribute__(self, name: str):
                     i for i in new_column._meta.call_chain
                 ]
                 _column._meta.call_chain.append(new_column)
-                if _column._meta.name == "id":
-                    continue
                 setattr(new_column, _column._meta.name, _column)
                 foreign_key_meta.proxy_columns.append(_column)
 

Original file line number	Diff line number	Diff line change
`@@ -1199,8 +1199,6 @@ def __getattribute__(self, name: str):`
`1199`	`1199`	`i for i in new_column._meta.call_chain`
`1200`	`1200`	`]`
`1201`	`1201`	`_column._meta.call_chain.append(new_column)`
`1202`		`- if _column._meta.name == "id":`
`1203`		`- continue`
`1204`	`1202`	`setattr(new_column, _column._meta.name, _column)`
`1205`	`1203`	`foreign_key_meta.proxy_columns.append(_column)`
`1206`	`1204`