Skip to content

Commit 1869627

Browse files
committed
fixing bug with diffing
1 parent 0e29264 commit 1869627

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

piccolo/apps/migrations/auto/diffable_table.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,16 +85,17 @@ def __sub__(self, value: DiffableTable) -> TableDelta:
8585

8686
alter_columns: t.List[AlterColumn] = []
8787

88-
for column in value.columns:
89-
existing_column = self.columns_map.get(column._meta.name)
90-
if not existing_column:
88+
for existing_column in value.columns:
89+
column = self.columns_map.get(existing_column._meta.name)
90+
if not column:
9191
# This is a new column - already captured above.
9292
continue
9393

9494
delta = compare_dicts(
9595
serialise_params(column._meta.params).params,
9696
serialise_params(existing_column._meta.params).params,
9797
)
98+
9899
old_params = {
99100
key: existing_column._meta.params.get(key)
100101
for key, _ in delta.items()

0 commit comments

Comments
 (0)