Skip to content

Commit 0f9b2e3

Browse files
committed
fixing bug with dropping tables in auto migrations, and added test
1 parent d7a3a29 commit 0f9b2e3

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

piccolo/apps/migrations/auto/schema_differ.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ def drop_tables(self) -> AlterStatements:
241241

242242
return AlterStatements(
243243
statements=[
244-
f"manager.drop_table(tablename='{i.tablename}')"
244+
f"manager.drop_table(class_name='{i.class_name}', tablename='{i.tablename}')" # noqa
245245
for i in drop_tables
246246
]
247247
)

tests/apps/migrations/auto/test_schema_differ.py

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,19 @@ def test_drop_table(self):
2020
"""
2121
Test dropping an existing table.
2222
"""
23-
pass
23+
schema: t.List[DiffableTable] = []
24+
schema_snapshot: t.List[DiffableTable] = [
25+
DiffableTable(class_name="Band", tablename="band", columns=[])
26+
]
27+
schema_differ = SchemaDiffer(
28+
schema=schema, schema_snapshot=schema_snapshot, auto_input="y"
29+
)
30+
31+
self.assertTrue(len(schema_differ.drop_tables.statements) == 1)
32+
self.assertEqual(
33+
schema_differ.drop_tables.statements[0],
34+
"manager.drop_table(class_name='Band', tablename='band')",
35+
)
2436

2537
def test_rename_table(self):
2638
"""

0 commit comments

Comments
 (0)