Skip to content

Commit 06d2eb9

Browse files
committed
converted _parse_raw_version_string to a staticmethod
1 parent 6e0eda8 commit 06d2eb9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

piccolo/engine/postgres.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,8 @@ def __init__(self, config: t.Dict[str, t.Any]) -> None:
227227
)
228228
super().__init__()
229229

230-
def _parse_raw_version_string(self, version_string: str) -> float:
230+
@staticmethod
231+
def _parse_raw_version_string(version_string: str) -> float:
231232
"""
232233
The format of the version string isn't always consistent. Sometimes
233234
it's just the version number e.g. '9.6.18', and sometimes

tests/engine/test_version_parsing.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,17 @@ def test_version_parsing(self):
1111
Make sure the version number can correctly be parsed from a range
1212
of known formats.
1313
"""
14-
engine = PostgresEngine(config={})
15-
1614
self.assertEqual(
17-
engine._parse_raw_version_string(version_string="9.4"), 9.4
15+
PostgresEngine._parse_raw_version_string(version_string="9.4"), 9.4
1816
)
1917

2018
self.assertEqual(
21-
engine._parse_raw_version_string(version_string="9.4.1"), 9.4
19+
PostgresEngine._parse_raw_version_string(version_string="9.4.1"),
20+
9.4,
2221
)
2322

2423
self.assertEqual(
25-
engine._parse_raw_version_string(
24+
PostgresEngine._parse_raw_version_string(
2625
version_string="12.4 (Ubuntu 12.4-0ubuntu0.20.04.1)"
2726
),
2827
12.4,

0 commit comments

Comments
 (0)