raising a ValueError if is_in or not_in query clauses are passed an empty list

Otherwise invalid SQL is generated.

Author: dantownsend

piccolo/apps/migrations/commands/clean.py

@@ -27,13 +27,16 @@ def get_migration_ids_to_remove(self) -> t.List[str]:
             migration_module_dict=migration_module_dict
         )
 
-        migration_ids_to_remove = (
+        query = (
             Migration.select(Migration.name)
             .where(Migration.app_name == self.app_name)
-            .where(Migration.name.not_in(migration_ids))
             .output(as_list=True)
-            .run_sync()
         )
+
+        if len(migration_ids) > 0:
+            query = query.where(Migration.name.not_in(migration_ids))
+
+        migration_ids_to_remove = query.run_sync()
         return migration_ids_to_remove
 
     def run(self):

piccolo/columns/base.py

@@ -24,7 +24,6 @@
 )
 from piccolo.columns.combination import Where
 from piccolo.columns.defaults.base import Default
-from piccolo.custom_types import Iterable
 from piccolo.querystring import QueryString
 from piccolo.utils.warnings import colored_warning
 
@@ -257,10 +256,18 @@ def _validate_default(
                 f"{allowed_types}"
             )
 
-    def is_in(self, values: Iterable) -> Where:
+    def is_in(self, values: t.List[t.Any]) -> Where:
+        if len(values) == 0:
+            raise ValueError(
+                "The `values` list argument must contain at least one value."
+            )
         return Where(column=self, values=values, operator=In)
 
-    def not_in(self, values: Iterable) -> Where:
+    def not_in(self, values: t.List[t.Any]) -> Where:
+        if len(values) == 0:
+            raise ValueError(
+                "The `values` list argument must contain at least one value."
+            )
         return Where(column=self, values=values, operator=NotIn)
 
     def like(self, value: str) -> Where:

tests/columns/test_combination.py

@@ -24,7 +24,13 @@ def test_is_in(self):
         sql = _where.__str__()
         self.assertEqual(sql, "band.name IN ('Pythonistas', 'Rustaceans')")
 
+        with self.assertRaises(ValueError):
+            Band.name.is_in([])
+
     def test_not_in(self):
         _where = Band.name.not_in(["CSharps"])
         sql = _where.__str__()
         self.assertEqual(sql, "band.name NOT IN ('CSharps')")
+
+        with self.assertRaises(ValueError):
+            Band.name.not_in([])