fix(overmind): fix issue with bound proxy on statemachines

Author: christianalfoni

packages/node_modules/overmind/src/index.ts

@@ -43,12 +43,10 @@ import {
   IOnInitialize,
   IOperator,
   IReaction,
-  IState,
 } from './types'
 import {
   EXECUTION,
   IS_OPERATOR,
-  IS_PROXY_BOUND_FUNCTION,
   IS_TEST,
   MODE_DEFAULT,
   MODE_SSR,
@@ -394,16 +392,14 @@ export class Overmind<ThisConfig extends IConfiguration>
       {
         devmode,
         delimiter: this.delimiter,
-        onSetFunction: (proxy, tree, path, target, prop, func) => {
+        onSetFunction: (tree, path, target, prop, func) => {
           if (func[IS_DERIVED_CONSTRUCTOR]) {
             return new Derived(func) as any
           }
 
-          func = func.bind(proxy)
-          func[IS_PROXY_BOUND_FUNCTION] = true
           return func
         },
-        onGetFunction: (proxy, tree, path, target, prop) => {
+        onGetFunction: (tree, path, target, prop) => {
           let func = target[prop]
 
           if (func[IS_DERIVED]) {
@@ -417,13 +413,6 @@ export class Overmind<ThisConfig extends IConfiguration>
             return derived(eventHub, tree, proxyStateTree, path.split(this.delimiter))
           }
 
-          if (func[IS_PROXY_BOUND_FUNCTION]) {
-            return func
-          }
-
-          func = func.bind(proxy)
-          func[IS_PROXY_BOUND_FUNCTION] = true
-          target[prop] = func
           return func
         },    
         onGetter: devmode

packages/node_modules/overmind/src/utils.ts

@@ -5,7 +5,6 @@ export const IS_TEST = process.env.NODE_ENV === 'test'
 export const IS_OPERATOR = Symbol('operator')
 export const ORIGINAL_ACTIONS = Symbol('origina_actions')
 export const EXECUTION = Symbol('execution')
-export const IS_PROXY_BOUND_FUNCTION = Symbol('is_proxy_bound_function')
 
 export const MODE_DEFAULT = Symbol('MODE_DEFAULT')
 export const MODE_TEST = Symbol('MODE_TEST')

packages/node_modules/proxy-state-tree/src/Proxyfier.ts

@@ -261,14 +261,13 @@ export class Proxifier {
         if (typeof targetValue === 'function') {
           if (proxifier.tree.master.options.onGetFunction) {
             return proxifier.tree.master.options.onGetFunction(
-              proxy,
               trackingTree || proxifier.tree,
               nestedPath,
               target,
               prop
             )
           }
-          return isClass(target) ? (...args) => targetValue.call(proxy, ...args) : targetValue.call(target, proxifier.tree, nestedPath)
+          return isClass(target) ? targetValue : targetValue.call(target, proxifier.tree, nestedPath)
         } else {
           currentTree.trackPathListeners.forEach((cb) => cb(nestedPath))
           trackingTree && trackingTree.proxifier.trackPath(nestedPath)
@@ -299,7 +298,6 @@ export class Proxifier {
 
         if (typeof value === 'function' && proxifier.tree.master.options.onSetFunction) {
           value = proxifier.tree.master.options.onSetFunction(
-            proxy,
             proxifier.getTrackingTree() || proxifier.tree,
             nestedPath,
             target,

packages/node_modules/proxy-state-tree/src/index.test.ts

@@ -755,7 +755,7 @@ describe('FUNCTIONS', () => {
       },
     }
     const tree = new ProxyStateTree(state, {
-      onGetFunction: (proxy, proxyStateTree, path, target, prop) =>
+      onGetFunction: (proxyStateTree, path, target, prop) =>
         target[prop]('foo', proxyStateTree, path),
     })