feat(proxy-state-tree): add dispose function on adding mutation and flush listeners

christianalfoni · christianalfoni · commit f449263b80be · 2018-12-29T20:56:27.000+01:00
diff --git a/packages/node_modules/proxy-state-tree/src/index.ts b/packages/node_modules/proxy-state-tree/src/index.ts
@@ -121,9 +121,15 @@ export class ProxyStateTree<T extends object> implements IProxyStateTree<T> {
   }
   onMutation(callback: IMutationCallback) {
     this.mutationCallbacks.push(callback)
+
+    return () =>
+      this.mutationCallbacks.splice(this.mutationCallbacks.indexOf(callback), 1)
   }
   onFlush(callback: IFlushCallback) {
     this.flushCallbacks.push(callback)
+
+    return () =>
+      this.flushCallbacks.splice(this.flushCallbacks.indexOf(callback), 1)
   }
   addMutation(mutation: IMutation, objectChangePath?: string) {
     this.mutations.push(mutation)

Original file line number	Diff line number	Diff line change
`@@ -121,9 +121,15 @@ export class ProxyStateTree<T extends object> implements IProxyStateTree<T> {`
`121`	`121`	`}`
`122`	`122`	`onMutation(callback: IMutationCallback) {`
`123`	`123`	`this.mutationCallbacks.push(callback)`
	`124`	`+`
	`125`	`+ return () =>`
	`126`	`+ this.mutationCallbacks.splice(this.mutationCallbacks.indexOf(callback), 1)`
`124`	`127`	`}`
`125`	`128`	`onFlush(callback: IFlushCallback) {`
`126`	`129`	`this.flushCallbacks.push(callback)`
	`130`	`+`
	`131`	`+ return () =>`
	`132`	`+ this.flushCallbacks.splice(this.flushCallbacks.indexOf(callback), 1)`
`127`	`133`	`}`
`128`	`134`	`addMutation(mutation: IMutation, objectChangePath?: string) {`
`129`	`135`	`this.mutations.push(mutation)`