fix(overmind): generally fix circular reference classes

Author: christianalfoni

packages/node_modules/overmind/src/Devtools.ts

@@ -11,19 +11,10 @@ export type DevtoolsMessage = {
   data: any
 }
 
-function isClass(value: any) {
-  return (
-    typeof value === 'object' &&
-    !Array.isArray(value) && 
-    value !== null &&
-    value.constructor &&
-    value.constructor.name !== 'Object'
-  )
-}
-
 export class Devtools {
   private safeClassNames: Set<string> = new Set()
   private unsafeClassNames: Set<string> = new Set()
+  private circularReferenceCache: any[] = []
   private buffer: string[] = []
   private ws: WebSocket
   private isConnected: boolean = false
@@ -81,6 +72,7 @@ export class Devtools {
   send(message: Message) {
     const safeClassNames = this.safeClassNames
     const unsafeClassNames = this.unsafeClassNames
+    const circularReferenceCache = this.circularReferenceCache
     const stringifiedMessage = JSON.stringify(
       message,
       function (_, value) {
@@ -100,26 +92,19 @@ export class Devtools {
           }
         }
 
-        if (Array.isArray(value) && isClass(value[0])) {
-          if (!safeClassNames.has(value[0].constructor.name) && !unsafeClassNames.has(value[0].constructor.name)) {
-            try {
-              JSON.stringify(value[0])
-              safeClassNames.add(value[0].constructor.name)
-            } catch {
-              unsafeClassNames.add(value[0].constructor.name)
-            }
+        if (
+          typeof value === 'object' &&
+          value !== null &&
+          !Array.isArray(value) &&
+          value.constructor &&
+          value.constructor.name !== 'Object'
+        ) {
+          if (circularReferenceCache.includes(value)) {
+            return `[CIRCULAR REFERENCE: ${value.constructor.name}]`
           }
-          
-          if (safeClassNames.has(value[0].constructor.name)) {
-            return value.map((item) => ({
-              __CLASS__: true,
-              name: value[0].constructor.name,
-              value: item
-            }))
-          } else {
-            return value.map(() => `[${value.constructor.name || 'NOT SERIALIZABLE'}]`)
-          }
-        } else if (isClass(value)) {
+
+          circularReferenceCache.push(value)
+
           if (!safeClassNames.has(value.constructor.name) && !unsafeClassNames.has(value.constructor.name)) {
             try {
               JSON.stringify(value)
@@ -144,6 +129,7 @@ export class Devtools {
       },
       0
     )
+    circularReferenceCache.length = 0
     this.buffer.push(stringifiedMessage)
     this.sendBuffer()
   }