fix(overmind): properly extract any nested action

Author: christianalfoni

packages/node_modules/overmind/src/index.ts

@@ -345,7 +345,7 @@ export class Overmind<ThisConfig extends IConfiguration>
     /*
       Expose the created actions
     */
-    this.actions = this.getActions(configuration)
+    this.actions = this.getActions(configuration.actions)
 
     if (mode.mode === MODE_DEFAULT && configuration.onInitialize) {
       const onInitialize = this.createAction(
@@ -781,51 +781,22 @@ export class Overmind<ThisConfig extends IConfiguration>
       return aggr
     }, {})
   }
-  private getActions(configuration: IConfiguration) {
-    let actions = {}
-    if (configuration.actions) {
-      actions = configuration.actions
-    }
-
-    const evaluatedActions = Object.keys(actions).reduce((aggr, name) => {
+  private getActions(actions: any = {}, path: string[] = []) {
+    return Object.keys(actions).reduce((aggr, name) => {
       if (typeof actions[name] === 'function') {
+        const action = this.createAction(name, actions[name]) as any
+
+        action.displayName = path.concat(name).join('.')
+
         return Object.assign(aggr, {
-          [name]: this.createAction(name, actions[name]),
+          [name]: action,
         })
       }
 
       return Object.assign(aggr, {
-        [name]: Object.keys(actions[name] || {}).reduce(
-          (aggr, subName) =>
-            Object.assign(
-              aggr,
-              typeof actions[name][subName] === 'function'
-                ? {
-                    [subName]: this.createAction(
-                      subName,
-                      actions[name][subName]
-                    ),
-                  }
-                : {}
-            ),
-          {}
-        ),
+        [name]: this.getActions(actions[name], path.concat(name)),
       })
     }, {}) as any
-
-    if (this.devtools) {
-      Object.keys(evaluatedActions).forEach((key) => {
-        if (typeof evaluatedActions[key] === 'function') {
-          evaluatedActions[key].displayName = key
-        } else {
-          Object.keys(evaluatedActions[key]).forEach((subKey) => {
-            evaluatedActions[key][subKey].displayName = key + '.' + subKey
-          })
-        }
-      })
-    }
-
-    return evaluatedActions
   }
   getTrackStateTree() {
     return this.proxyStateTree.getTrackStateTree()
@@ -852,7 +823,7 @@ export class Overmind<ThisConfig extends IConfiguration>
     this.proxyStateTree.sourceState = this.getState(mergedConfiguration)
     proxyStateTree.createTrackStateProxifier()
     this.state = this.proxyStateTree.state as any
-    this.actions = this.getActions(mergedConfiguration)
+    this.actions = this.getActions(mergedConfiguration.actions)
     this.effects = mergedConfiguration.effects || {}
 
     this.proxyStateTree.forceFlush()

packages/node_modules/overmind/src/utils.ts

@@ -115,6 +115,14 @@ export function createActionsProxy(actions, cb) {
         return cb(target[prop])
       }
 
+      if (!target[prop]) {
+        throw new Error(
+          `You are pointing towards an action that does not exist. "${String(
+            prop
+          )}" does not exist`
+        )
+      }
+
       return createActionsProxy(target[prop], cb)
     },
   })