fix(proxy-state-tree): only remove array proxies when actually doing an array mutation

Author: christianalfoni

packages/node_modules/overmind/src/index.ts

@@ -525,15 +525,21 @@ export class Overmind<Config extends Configuration> implements Configuration {
       if (key === '__esModule') {
         return aggr
       }
+      const originalDescriptor = Object.getOwnPropertyDescriptor(state, key)
+
+      if (originalDescriptor && 'get' in originalDescriptor) {
+        Object.defineProperty(aggr, key, originalDescriptor as any)
+
+        return aggr
+      }
 
       const value = state[key]
+
       if (isPlainObject(value)) {
         aggr[key] = this.processState(value)
       } else if (typeof value === 'function') {
         aggr[key] = new Derived(value)
       } else {
-        var originalDescriptor = Object.getOwnPropertyDescriptor(state, key)
-
         Object.defineProperty(aggr, key, originalDescriptor as any)
       }
 

packages/node_modules/proxy-state-tree/src/Proxyfier.ts

@@ -181,19 +181,19 @@ export class Proxifier {
 
             const method = String(prop)
 
-            // On POP we can optimally remove cached proxy by removing the specific one
-            // that was removed. If it is a PUSH, we do not have to remove anything, as
-            // existing proxies stays the same
-            if (method === 'pop') {
-              proxifier.tree.master.removeProxy(nestedPath)
-            } else if (method !== 'push') {
-              proxifier.tree.master.removeProxy(path)
-            }
-
             if (
-              arrayMutations.has(String(prop)) &&
+              arrayMutations.has(method) &&
               proxifier.shouldTrackMutations(nestedPath)
             ) {
+              // On POP we can optimally remove cached proxy by removing the specific one
+              // that was removed. If it is a PUSH, we do not have to remove anything, as
+              // existing proxies stays the same
+              if (method === 'pop') {
+                proxifier.tree.master.removeProxy(nestedPath)
+              } else if (method !== 'push') {
+                proxifier.tree.master.removeProxy(path)
+              }
+
               proxifier.ensureMutationTrackingIsEnabled(nestedPath)
               return (...args) => {
                 const mutationTree = proxifier.getMutationTree()