refactor(overmind): statecharts transition should happen before action runs

christianalfoni · christianalfoni · commit d6269d74ba4f · 2019-10-13T22:15:59.000+02:00
diff --git a/packages/node_modules/overmind/src/config/statechart.ts b/packages/node_modules/overmind/src/config/statechart.ts
@@ -198,8 +198,6 @@ export function statechart<C extends IConfiguration, S extends string>(
             return actions[key](context, payload)
           }
 
-          const result = actions[key](context, payload)
-
           const stateTarget = getTarget(
             context.state,
             context.execution.namespacePath
@@ -283,7 +281,7 @@ export function statechart<C extends IConfiguration, S extends string>(
             })
           }
 
-          return result
+          return actions[key](context, payload)
         })
       )
 

Original file line number	Diff line number	Diff line change
`@@ -198,8 +198,6 @@ export function statechart<C extends IConfiguration, S extends string>(`
`198`	`198`	`return actions[key](context, payload)`
`199`	`199`	`}`
`200`	`200`
`201`		`- const result = actions[key](context, payload)`
`202`		`-`
`203`	`201`	`const stateTarget = getTarget(`
`204`	`202`	`context.state,`
`205`	`203`	`context.execution.namespacePath`
`@@ -283,7 +281,7 @@ export function statechart<C extends IConfiguration, S extends string>(`
`283`	`281`	`})`
`284`	`282`	`}`
`285`	`283`
`286`		`- return result`
	`284`	`+ return actions[key](context, payload)`
`287`	`285`	`})`
`288`	`286`	`)`
`289`	`287`