fix(overmind): ensure bound execution is actually an execution

Author: christianalfoni

packages/node_modules/overmind/src/index.ts

@@ -45,6 +45,7 @@ import {
   getFunctionName,
   getActionPaths,
   createActionsProxy,
+  EXECUTION,
 } from './utils'
 import {
   operatorStarted,
@@ -389,6 +390,7 @@ export class Overmind<ThisConfig extends IConfiguration>
   private createExecution(name, action, parentExecution) {
     if (IS_PRODUCTION) {
       return ({
+        [EXECUTION]: true,
         parentExecution,
         getMutationTree: () => {
           return this.proxyStateTree.getMutationTree()
@@ -399,6 +401,7 @@ export class Overmind<ThisConfig extends IConfiguration>
 
     const mutationTrees: any[] = []
     const execution = {
+      [EXECUTION]: true,
       actionId: this.actionReferences.indexOf(action),
       executionId: this.nextExecutionId++,
       actionName: name,
@@ -474,6 +477,11 @@ export class Overmind<ThisConfig extends IConfiguration>
   private createAction(name, action) {
     this.actionReferences.push(action)
     const actionFunc = (value?, boundExecution?: Execution) => {
+      // Developer might unintentionally pass more arguments, so have to ensure
+      // that it is an actual execution
+      boundExecution =
+        boundExecution && boundExecution[EXECUTION] ? boundExecution : undefined
+
       if (IS_PRODUCTION || action[IS_OPERATOR]) {
         const execution = this.createExecution(name, action, boundExecution)
         this.eventHub.emit(EventType.ACTION_START, {

packages/node_modules/overmind/src/utils.ts

@@ -8,6 +8,7 @@ export const IS_DEVELOPMENT =
   !process.env.NODE_ENV || process.env.NODE_ENV === 'development'
 export const IS_OPERATOR = Symbol('operator')
 export const ORIGINAL_ACTIONS = Symbol('origina_actions')
+export const EXECUTION = Symbol('execution')
 
 export class MockedEventEmitter {
   emit() {}