Merge pull request cerebral#256 from CharlotteBeebee/next

FIX Throw error during merge if encounter duplicate keys

Author: christianalfoni

packages/node_modules/overmind/src/config/index.ts

@@ -110,8 +110,20 @@ export function merge(...configurations: IConfiguration[]): IConfiguration {
     [] as any[]
   )
 
-  return configurations.reduce(
+  const reducedConfigurations = configurations.reduce(
     (aggr, config) => {
+      const stateDuplicates = aggr.state ? Object.keys(aggr.state).some( key => config.state ? Object.keys(config.state).includes(key) : false) : false;
+      const actionsDuplicates = aggr.actions ? Object.keys(aggr.actions).some( key => config.actions ? Object.keys(config.actions).includes(key) : false) : false;
+      const effectsDuplicates = aggr.effects ? Object.keys(aggr.effects).some( key => config.effects ? Object.keys(config.effects).includes(key) : false) : false;
+      if (stateDuplicates){
+        throw new Error("Merge conflict: at least one state definition contains a duplicate key")
+      }
+      if (actionsDuplicates) {
+        throw new Error("Merge conflict: at least one actions definition contains a duplicate key")
+      }
+      if (effectsDuplicates) {
+        throw new Error("Merge conflict: at least one effects definition contains a duplicate key")
+      }
       return {
         onInitialize: aggr.onInitialize,
         state: {
@@ -138,6 +150,7 @@ export function merge(...configurations: IConfiguration[]): IConfiguration {
       actions: {},
     }
   )
+  return reducedConfigurations
 }
 
 /*