fix(proxy-state-tree): fix removing listener of mutationtree path tracking

christianalfoni · christianalfoni · commit bfcee0128467 · 2019-09-26T21:54:24.000+02:00
diff --git a/packages/node_modules/proxy-state-tree/src/MutationTree.ts b/packages/node_modules/proxy-state-tree/src/MutationTree.ts
@@ -27,10 +27,13 @@ export class MutationTree<T extends object> implements IMutationTree<T> {
     const listener = (path) => {
       paths.add(path)
     }
-    const index = this.trackPathListeners.push(listener) - 1
+    this.trackPathListeners.push(listener)
 
     return () => {
-      this.trackPathListeners.splice(index, 1)
+      this.trackPathListeners.splice(
+        this.trackPathListeners.indexOf(listener),
+        1
+      )
 
       return paths
     }

Original file line number	Diff line number	Diff line change
`@@ -27,10 +27,13 @@ export class MutationTree<T extends object> implements IMutationTree<T> {`
`27`	`27`	`const listener = (path) => {`
`28`	`28`	`paths.add(path)`
`29`	`29`	`}`
`30`		`- const index = this.trackPathListeners.push(listener) - 1`
	`30`	`+ this.trackPathListeners.push(listener)`
`31`	`31`
`32`	`32`	`return () => {`
`33`		`- this.trackPathListeners.splice(index, 1)`
	`33`	`+ this.trackPathListeners.splice(`
	`34`	`+ this.trackPathListeners.indexOf(listener),`
	`35`	`+ 1`
	`36`	`+ )`
`34`	`37`
`35`	`38`	`return paths`
`36`	`39`	`}`