Merge pull request cerebral#501 from schiller-manuel/wait-for-async-onInitializeOvermind

fix(overmind-statechart): wait for async onInitializeOvermind

Author: christianalfoni

packages/node_modules/overmind-statechart/src/index.test.ts

@@ -172,6 +172,61 @@ describe('Statecharts', () => {
     expect(instance.state.count).toBe(1)
   })
 
+  test('async onInitializeOvermind is finished before instance is initialized', async () => {
+    const onInitializeOvermind = async ({actions}: Context) => {
+      await new Promise(r=>setTimeout(r, 250));
+      await actions.increaseCount();
+    }
+    const increaseCount = async ({ state }: Context) => {
+      state.count++;
+    }
+    const state = {
+      count: 0,
+    }
+    const actions = {
+      onInitializeOvermind,
+      increaseCount
+    }
+
+    const config = {
+      state,
+      actions,
+    }
+
+    const chart: Statechart<
+      Context,
+      {
+        foo: void,
+        bar: void
+      }
+    > = {
+      initial: 'foo',
+      states: {
+        foo: {
+          on: {
+            'increaseCount': 'bar'
+          }
+        },
+        bar:{}
+      }
+    }
+
+    type Context = IContext<{
+      state: typeof state,
+      actions: typeof actions
+    }>
+
+    const instance = createOvermind(
+      statechart(config, {
+        id1: chart,
+      }
+      ))
+
+    await instance.initialized
+    expect(instance.state.states).toEqual([['id1', 'bar']])
+    expect(instance.state.count).toBe(1)
+  })
+
   test('should run entry action', () => {
     const increaseCount = ({ state }: Context) => {
       state.count++
@@ -224,7 +279,7 @@ describe('Statecharts', () => {
     expect(instance.state.count).toBe(1)
   })
 
-  test('should run entry action of initial state when onInitializeOvermind is present', () => {
+  test('should run entry action of initial state when onInitializeOvermind is present', async () => {
     const onInitializeOvermind = ({ state }: Context) => {
       state.initCount++
     }
@@ -268,7 +323,8 @@ describe('Statecharts', () => {
         id1: chart,
       })
     )
-
+    
+    await instance.initialized
     expect(instance.state.states).toEqual([['id1', 'foo']])
     expect(instance.state.actions).toEqual({ increaseCount: false})
     expect(

packages/node_modules/overmind-statechart/src/index.ts

@@ -294,9 +294,9 @@ export function statechart<
 
   const initialActions = {
     [ACTIONS]: copiedActions,
-    onInitializeOvermind: ((context, instance) => {
+    onInitializeOvermind:  ( async (context, instance) => {
       if (onInitializeOvermindAction) {
-        onInitializeOvermindAction(context, instance)
+         await onInitializeOvermindAction(context, instance)
       }
 
       currentInstance = instance