feat(overmind): devtools client can receive port

Author: eirikhm

packages/node_modules/overmind-devtools-client/src/BackendConnector.ts

@@ -12,10 +12,18 @@ class WebsocketConnector {
   private callbacks: {
     [event: string]: Function[]
   } = {}
-  private socket = new WebSocket('ws://localhost:3031?devtools=1') // TODO should be able to configure
+  private socket:WebSocket;
   private messagesBeforeConnected: Array<[string, any, any]> = []
   private isOpen = false
-  constructor() {
+  
+
+  public open(port:string) // TODO: return Promise so we can wait for it
+  {
+    if (this.socket)
+    {
+      throw new Error("TODO: Socked already open, what now?");
+    }
+    this.socket = new WebSocket(`ws://localhost:${port}?devtools=1`)
     this.socket.onmessage = (message) => {
       const parsedMessage = JSON.parse(message.data)
 

packages/node_modules/overmind-devtools-client/src/overmind/onInitialize.ts

@@ -1,19 +1,29 @@
 import { OnInitialize } from 'overmind'
 
 const onInitialize: OnInitialize = async ({ state, effects }, app) => {
-  const port = await effects.storage.get<string>('currentPort')
-  const runtimeHost = await effects.storage.get<string>('runtimeHost')
+  
+  // We cannot use storage here since it depends on connector, which is not open yet since we do not know the host!
+  // let port = await effects.storage.get<string>('currentPort')
+  // const runtimeHost = await effects.storage.get<string>('runtimeHost')
+
+  let port = "3301"; // TODO: const default port somewhere
+  if (window['__OVERMIND_DEVTOOLS_BACKEND_PORT__'])
+  {
+    port = window['__OVERMIND_DEVTOOLS_BACKEND_PORT__'];
+  }
 
   if (port) {
     state.port = port
   }
 
-  if (runtimeHost) {
-    state.runtimeHost = runtimeHost
-  }
+  effects.connector.open(state.port)
+  
+  // if (runtimeHost) {
+  //   state.runtimeHost = runtimeHost
+  // }
 
   effects.connector.onMessage(app.actions.onMessage)
-  effects.connector.connect(state.port)
+  // effects.connector.connect(state.port) // This should no longer be needed. DevtoolBackend does nothing when receing.
 }
 
 export default onInitialize