fix(overmind): fix merging getters

Author: christianalfoni

packages/node_modules/overmind/src/config/config.test.ts

@@ -1,5 +1,5 @@
-import { merge, namespaced, lazy } from './'
 import { Overmind } from '../'
+import { lazy, merge, namespaced } from './'
 
 describe('Config', () => {
   test('should merge configs', () => {

packages/node_modules/overmind/src/config/merge.ts

@@ -1,5 +1,33 @@
+import isPlainObject from 'is-plain-obj'
+
 import { IConfiguration } from '../'
 
+function copy(target, source) {
+  return Object.keys(source).reduce((aggr, key) => {
+    if (key === '__esModule') {
+      return aggr
+    }
+
+    if (isPlainObject(source[key])) {
+      aggr[key] = copy(target[key] || {}, source[key])
+    } else if (Array.isArray(source[key])) {
+      aggr[key] = source[key]
+    } else {
+      const originalDescriptor = Object.getOwnPropertyDescriptor(source, key)
+      const isAGetter = originalDescriptor && 'get' in originalDescriptor
+      const value = source[key]
+
+      if (isAGetter) {
+        Object.defineProperty(aggr, key, originalDescriptor as any)
+      } else {
+        aggr[key] = value
+      }
+    }
+
+    return aggr
+  }, target)
+}
+
 export function merge<A extends IConfiguration, B extends IConfiguration>(
   configA: A,
   configB: B
@@ -94,6 +122,9 @@ export function merge<
   configH: H,
   configI: I
 ): A & B & C & D & E & F & G & H & I
+
+
+
 export function merge(...configurations: IConfiguration[]): IConfiguration {
   const initializers = configurations.reduce(
     (aggr, config) =>
@@ -135,10 +166,7 @@ export function merge(...configurations: IConfiguration[]): IConfiguration {
       }
       return {
         onInitialize: aggr.onInitialize,
-        state: {
-          ...aggr.state,
-          ...config.state,
-        },
+        state: copy(aggr.state, config.state || {}),
         effects: {
           ...aggr.effects,
           ...config.effects,