Merge pull request cerebral#150 from etienne-dldc/fix/devtool-port-switch

christianalfoni · web-flow · commit a76f27bea365 · 2018-11-20T15:08:32.000+01:00
Fix devtools port switch
diff --git a/packages/node_modules/overmind-devtools/backend/ConnectionManager.js b/packages/node_modules/overmind-devtools/backend/ConnectionManager.js
@@ -27,11 +27,16 @@ class ConnectionManager {
     this.ws.send(JSON.stringify(payload))
   }
   connect(_, port) {
-    if (this.wss) {
+    if (this.port === port) {
       return
     }
 
-    this.wss = new WebSocketServer({ port: Number(port) })
+    if (this.wss) {
+      this.wss.close()
+    }
+
+    this.port = Number(port)
+    this.wss = new WebSocketServer({ port: this.port })
     this.wss.on('connection', this.onConnection)
     this.wss.on('error', this.onError)
   }

Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,16 @@ class ConnectionManager {`
`27`	`27`	`this.ws.send(JSON.stringify(payload))`
`28`	`28`	`}`
`29`	`29`	`connect(_, port) {`
`30`		`- if (this.wss) {`
	`30`	`+ if (this.port === port) {`
`31`	`31`	`return`
`32`	`32`	`}`
`33`	`33`
`34`		`- this.wss = new WebSocketServer({ port: Number(port) })`
	`34`	`+ if (this.wss) {`
	`35`	`+ this.wss.close()`
	`36`	`+ }`
	`37`	`+`
	`38`	`+ this.port = Number(port)`
	`39`	`+ this.wss = new WebSocketServer({ port: this.port })`
`35`	`40`	`this.wss.on('connection', this.onConnection)`
`36`	`41`	`this.wss.on('error', this.onError)`
`37`	`42`	`}`