Skip to content

Commit a578e60

Browse files
Merge branch 'vscode' of https://github.com/cerebral/overmind into vscode
2 parents 4bde946 + f9d1bc7 commit a578e60

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

packages/node_modules/overmind-devtools-vscode/package.json

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,23 @@
2020
"title": "Overmind Devtools",
2121
"type": "object",
2222
"properties": {
23-
"overmind-devtools.port": {
23+
"overmind.port": {
2424
"default": 3031,
2525
"description": "Port for devtools backend server",
2626
"type": "number"
2727
},
28-
"overmind-devtools.verbose": {
29-
"default": "",
28+
"overmind.devmode.url": {
29+
"default": "http://localhost:8080/bundle.js",
30+
"description": "Where to look for overmind-devtools-client in devmode",
31+
"type": "string"
32+
},
33+
"overmind.devmode.enabled": {
34+
"default": false,
35+
"description": "Enable devmode. Will serve client from specified url",
36+
"type": "boolean"
37+
},
38+
"overmind.logging.verbose": {
39+
"default": false,
3040
"description": "Toggles verbose logging",
3141
"type": "boolean"
3242
}

packages/node_modules/overmind-devtools-vscode/src/extension.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,16 +56,16 @@ export function activate(context: vscode.ExtensionContext) {
5656

5757
function startDevtools() {
5858
const port: number =
59-
vscode.workspace.getConfiguration().get('overmind-devtools.port') || 3031
59+
vscode.workspace.getConfiguration().get('overmind.port') || 3031
6060

6161
devtoolBackend
6262
.connect(port)
6363
.then(() => {
6464
let scriptFile: vscode.Uri | string
6565

6666
// TODO consider https://github.com/microsoft/vscode/commit/fbcdb4c6a736ff38e60a7e9d0a3f1be5ccbaf3af ?
67-
if (process.env.VSCODE_DEBUG_MODE) {
68-
scriptFile = 'http://localhost:8080/bundle.js'
67+
if (process.env.VSCODE_DEBUG_MODE || vscode.workspace.getConfiguration().get('overmind.devmode.enabled')) {
68+
scriptFile = <string>vscode.workspace.getConfiguration().get('overmind.devmode.url')
6969
} else {
7070
const onDiskPath = vscode.Uri.file(
7171
path.join(context.extensionPath, 'devtoolsDist', 'bundle.js')

0 commit comments

Comments
 (0)