fix(overmind): should proxify effects more dynamically

Author: christianalfoni

packages/node_modules/overmind/src/index.ts

@@ -678,6 +678,7 @@ export class Overmind<ThisConfig extends IConfiguration>
     return actionFunc
   }
   private trackEffects(effects = {}, execution) {
+    
     if (process.env.NODE_ENV === 'production') {
       return effects
     }

packages/node_modules/overmind/src/proxyfyEffects.ts

@@ -7,59 +7,36 @@ function isObject(value) {
 let hasWarnedConstructor = false
 let currentEffectId = 0
 
-function wrapEffect(target, prop, path, cb) {
-  const func = function(...args) {
-    const effectId = currentEffectId++
-
-    return cb({
-      func: target[prop].bind(target),
-      effectId,
-      name: path,
-      method: prop,
-      args,
-    })
-  }
-
-  return new Proxy(func, {
-    construct(_, args) {
+export function proxifyEffects<Effects>(
+  effects: Effects,
+  cb: (effect) => void,
+  path: string = ''
+): Effects {
+  return new Proxy(effects as any, {
+    apply(target, thisArg, agumentsList) {
+      const effectId = currentEffectId++
+      const name = path.split('.')
+      const method = name.pop()
+      return cb({
+        func: target.bind(thisArg),
+        effectId,
+        name: name.join('.'),
+        method,
+        args: agumentsList,
+      })
+    },
+    construct(Target, args) {
       if (!hasWarnedConstructor) {
         console.warn(
-          `EFFECTS - It is highly recommended to create a custom effect, exposing a method that deals with the instantiation of "${path}.${prop.toString()}". It improves readability and debugability of your app`
+          `EFFECTS - It is highly recommended to create a custom effect, exposing a method that deals with the instantiation of "${path}". It improves readability and debugability of your app`
         )
         hasWarnedConstructor = true
       }
 
-      return new target[prop](...args)
+      return new Target(...args)
     },
-  })
-}
-
-function createProxyGetHandler(
-  path: string,
-  cb: (effect) => void
-): ProxyHandler<any>['get'] {
-  return (target, prop) => {
-    if (typeof target[prop] === 'function') {
-      return wrapEffect(target, prop, path, cb)
+    get(target, prop) {
+      return proxifyEffects(target[prop], cb, path ? path + '.' + prop.toString() : prop.toString())
     }
-
-    if (isObject(target[prop])) {
-      return new Proxy(target[prop], {
-        get: createProxyGetHandler(
-          path ? path + '.' + prop.toString() : prop.toString(),
-          cb
-        ),
-      })
-    }
-    return target[prop]
-  }
-}
-
-export function proxifyEffects<Effects>(
-  effects: Effects,
-  cb: (effect) => void
-): Effects {
-  return new Proxy(effects, {
-    get: createProxyGetHandler('', cb),
   })
 }