Skip to content

Commit 9557abd

Browse files
committed
fix(overmind): fix TApp to not produce \ if effects is empty
1 parent ee7bed7 commit 9557abd

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

packages/node_modules/overmind/src/internalTypes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,6 @@ export type ResolveActions<Actions extends { [key: string]: any }> = {
106106
: {
107107
[P in keyof Actions[T]]: Actions[T][P] extends Function
108108
? ReturnType<Actions[T][P]>
109-
: undefined
109+
: Actions[T][P]
110110
}
111111
}

packages/node_modules/overmind/src/types.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,12 @@ export interface TApp<Config extends Configuration> {
2424
state: ResolveState<Config['state'] & {}>
2525
// Transform actions into callable functions.
2626
actions: ResolveActions<Config['actions'] & {}>
27-
effects: Config['effects'] & {}
27+
effects: [Config['effects']] extends [void] ? {} : Config['effects'] & {}
2828
}
2929

30+
// type CheckEffects = TApp<{}>['effects'] // => should produce {}
31+
// type CheckActions = TApp<{}>['actions'] // => should produce {}
32+
3033
export type TContext<App extends BaseApp, Value> = TBaseContext<App> & {
3134
value: Value
3235
}

0 commit comments

Comments
 (0)