fix(overmind): allow flush when parent execution is done running

Author: christianalfoni

packages/node_modules/overmind/src/index.ts

@@ -306,7 +306,8 @@ export class Overmind<ThisConfig extends IConfiguration>
         proxyStateTree.getMutationTree().flush(true)
       })
       eventHub.on(EventType.ACTION_END, (execution) => {
-        if (!execution.parentExecution) proxyStateTree.getMutationTree().flush()
+        if (!execution.parentExecution || !execution.parentExecution.isRunning)
+          proxyStateTree.getMutationTree().flush()
       })
 
       let nextTick
@@ -332,7 +333,10 @@ export class Overmind<ThisConfig extends IConfiguration>
         }
       })
       eventHub.on(EventType.ACTION_END, (execution) => {
-        if (!execution.parentExecution) {
+        if (
+          !execution.parentExecution ||
+          !execution.parentExecution.isRunning
+        ) {
           const flushData = execution.flush()
 
           if (this.devtools && flushData.mutations.length) {
@@ -501,6 +505,7 @@ export class Overmind<ThisConfig extends IConfiguration>
                 effects: this.trackEffects(this.effects, execution),
               },
               (err, finalContext) => {
+                execution.isRunning = false
                 finalContext &&
                   this.eventHub.emit(EventType.ACTION_END, {
                     ...finalContext.execution,

packages/overmind-website/src/components/Guides/index.tsx

@@ -10,8 +10,6 @@ const Guides: SFC = () => {
     return <Loader />
   }
 
-  console.log(state.guides)
-
   return (
     <div className={styles.wrapper}>
       {state.guides.map((guide) => (

packages/overmind-website/src/overmind/onInitialize.ts

@@ -1,14 +1,14 @@
 import { OnInitialize } from 'overmind'
 
-const onInitialize: OnInitialize = async ({ effects, state }, app) => {
+const onInitialize: OnInitialize = async ({ effects, state, actions }) => {
   state.showViewHelp = !effects.storage.get('theme')
 
-  effects.router.route('/', app.actions.openHome)
-  effects.router.route('/guides', app.actions.openGuides)
-  effects.router.route('/guides/:type/:title', app.actions.openGuide)
-  effects.router.route('/videos', app.actions.openVideos)
-  effects.router.route('/videos/:title', app.actions.openVideo)
-  effects.router.route('/api/:title', app.actions.openApi)
+  effects.router.route('/', actions.openHome)
+  effects.router.route('/guides', actions.openGuides)
+  effects.router.route('/guides/:type/:title', actions.openGuide)
+  effects.router.route('/videos', actions.openVideos)
+  effects.router.route('/videos/:title', actions.openVideo)
+  effects.router.route('/api/:title', actions.openApi)
   effects.router.redirect('/api', '/api/action')
 
   effects.router.start()