fix(proxy-state-tree): properly fix indexOf issue

Author: christianalfoni

packages/node_modules/proxy-state-tree/src/Proxyfier.ts

@@ -47,6 +47,8 @@ export class Proxifier {
         }"`
       )
     }
+
+    return value
   }
 
   trackPath(path: string) {
@@ -102,7 +104,9 @@ export class Proxifier {
         if (prop === IS_PROXY) return true
         if (prop === PATH) return path
         if (prop === VALUE) return value
-
+        if (prop === 'indexOf') {
+          return (arg) => value.indexOf(arg && arg[IS_PROXY] ? arg[VALUE] : arg)
+        }
         if (
           prop === 'length' ||
           (typeof target[prop] === 'function' &&
@@ -112,10 +116,6 @@ export class Proxifier {
           return target[prop]
         }
 
-        if (prop === 'indexOf') {
-          return (arg) => value.indexOf(arg && arg[IS_PROXY] ? arg[VALUE] : arg)
-        }
-
         const trackingTree = proxifier.getTrackingTree()
         const nestedPath = proxifier.concat(path, prop)
         const currentTree = trackingTree || proxifier.tree
@@ -137,7 +137,11 @@ export class Proxifier {
               hasChangedValue: true,
             })
 
-            return target[prop](...args)
+            return target[prop](
+              ...args.map((arg) =>
+                proxifier.ensureValueDosntExistInStateTreeElsewhere(arg)
+              )
+            )
           }
         }
 

packages/node_modules/proxy-state-tree/src/index.test.ts

@@ -367,16 +367,6 @@ describe('ARRAYS', () => {
       mutationTree.flush()
       expect(currentProxy).not.toBe(newProxy)
     })
-
-    test('should track with indexOf', () => {
-      const state = {
-        foo: ['bar'],
-      }
-      const tree = new ProxyStateTree(state)
-      const accessTree = tree.getTrackStateTree().track(() => {})
-      expect(accessTree.state.foo.indexOf('bar')).toBe(0)
-      expect(accessTree.pathDependencies).toEqual(new Set(['foo', 'foo.0']))
-    })
   })
 
   describe('MUTATIONS', () => {