fix(overmind): properly dispose machines

Author: christianalfoni

packages/node_modules/overmind/src/statemachine.test.ts

@@ -456,7 +456,8 @@ describe('Statemachine', () => {
 
     expect(() => overmind.actions.transition()).not.toThrow()
   })
-  test('should dispose nested machines', async () => {
+  test('should dispose nested and base machines', async () => {
+    expect.assertions(3)
     type States = {
       current: 'FOO'
     } | {
@@ -470,13 +471,28 @@ describe('Statemachine', () => {
       current: 'BAR'
     }
 
-    const nested = statemachine<States>({
+    type BaseStates = {
+      current: 'FOO'
+    } | {
+      current: 'BAR',
+    }
+
+    const base = statemachine<BaseStates>({
       FOO: ['BAR'],
       BAR: ['FOO']
     }, {
       current: 'FOO'
     })
 
+    const nested = statemachine<States, { base: typeof base }>({
+      FOO: ['BAR'],
+      BAR: ['FOO']
+    }, {
+      current: 'FOO'
+    }, {
+      base
+    })
+
     const state = statemachine<ParentStates>({
       FOO: ['BAR'],
       BAR: ['FOO']
@@ -488,8 +504,14 @@ describe('Statemachine', () => {
       state.matches('FOO', (fooState) => {
         const ref = fooState.nested
         state.transition('BAR', {})
+        
         expect(fooState.nested).toBe(undefined)
+        ref.transition('BAR', {})
+        ref.base.transition('BAR', {})
+        ref.base
+        
         expect(ref.current).toBe('FOO')
+        expect(ref.base.current).toBe('FOO')
       })
     }
 

packages/node_modules/overmind/src/statemachine.ts

@@ -65,7 +65,12 @@ export class StateMachine<Base extends IState, States extends TStates, State ext
     return new StateMachine(this[TRANSITIONS], deepCopy(this[STATE]), deepCopy(this[BASE]))
   }
   private dispose() {
-    this
+    Object.keys(this[VALUE]).forEach((key) => {
+      if (this[VALUE][key] instanceof StateMachine) {
+        this[key].dispose()
+      }
+    })
+    this[VALUE][IS_DISPOSED] = true
   }
   constructor(transitions: StatemachineTransitions<States>, state: States, base: Base) {
     this[STATE] = state