fix(proxy-state-tree): avoid replicating proxies that already exists

Author: christianalfoni

packages/node_modules/proxy-state-tree/src/index.test.ts

@@ -965,4 +965,16 @@ describe('SCOPED', () => {
     expect(tree.get().foo).toBe('bar2')
     expect(scoped.get().foo).toBe('bar2')
   })
+  it('should not recreate proxy when exists', () => {
+    const tree = new ProxyStateTree({
+      foo: {
+        bar: 'baz',
+      },
+    })
+
+    const state = tree.get()
+
+    // eslint-disable-next-line
+    expect(state.foo === state.foo).toBe(true)
+  })
 })

packages/node_modules/proxy-state-tree/src/proxify.ts

@@ -186,15 +186,16 @@ function getValue(value, tree) {
     return value
   }
 
-  if (value[IS_PROXY]) {
-    return value[VALUE][tree.PROXY] || value[VALUE]
+  if (value[tree.PROXY]) {
+    return value[tree.PROXY]
   }
 
   return value
 }
 
 export function proxify(tree, value, path?) {
   value = getValue(value, tree)
+
   if (value) {
     if (value[IS_PROXY] && value[PATH] !== path) {
       delete value[VALUE][tree.PROXY]
@@ -210,6 +211,7 @@ export function proxify(tree, value, path?) {
         configurable: true,
         value: createObjectProxy(tree, value, path),
       })
+
       return value[tree.PROXY]
     } else if (Array.isArray(value)) {
       Object.defineProperty(value, tree.PROXY, {