refactor(overmind): flip state and value argument in mutation operator

Author: christianalfoni

packages/demos/todomvc/src/app/actions.ts

@@ -4,5 +4,5 @@ import { Action } from './'
 export default (action: Action) => ({
   changeNewTodoTitle: action<React.ChangeEvent<HTMLInputElement>>()
     .map((event) => event.currentTarget.value)
-    .mutation((state, value) => (state.newTodoTitle = value)),
+    .mutation((value, state) => (state.newTodoTitle = value)),
 })

packages/node_modules/overmind-devtools/src/client/app/actions.ts

@@ -26,33 +26,33 @@ const connectCurrentPort = (action: (message: any) => void) => (
   MUTATIONS
 */
 
-const setApps = (state: State, apps: Apps) => (state.apps = apps || {})
+const setApps = (apps: Apps, state: State) => (state.apps = apps || {})
 
-const setCurrentPort = (state: State, currentPort: string) => {
+const setCurrentPort = (currentPort: string, state: State) => {
   if (currentPort) {
     state.currentPort = currentPort
   } else if (Object.keys(state.apps).length) {
     state.currentPort = Object.keys(state.apps)[0]
   }
 }
 
-const setError = (state: State, error: string) => (state.error = error)
+const setError = (error: string, state: State) => (state.error = error)
 
-const setAppLoaded = (state: State) => (state.isLoading = false)
+const setAppLoaded = (_, state: State) => (state.isLoading = false)
 
-const setNewPortValue = (state: State, value: string) =>
+const setNewPortValue = (value: string, state: State) =>
   (state.newPortValue = value)
 
-const addNewApp = (state: State) =>
+const addNewApp = (_, state: State) =>
   (state.apps[state.newPortValue] = {
     name: null,
     port: state.newPortValue,
     messages: [],
   })
 
-const resetNewPortValue = (state: State) => (state.newPortValue = '')
+const resetNewPortValue = (_, state: State) => (state.newPortValue = '')
 
-const addMessageFromClient = (state: State, message: Message) => {
+const addMessageFromClient = (message: Message, state: State) => {
   state.apps[message.port].messages = state.apps[message.port].messages.concat(
     message.message
   )

packages/node_modules/overmind/src/createActionFactory.ts

@@ -14,7 +14,7 @@ type OperatorCallback<Context, Value, NewValue = Value> = (
 
 interface Operators<State, Context, InitialValue, Value> {
   mutation(
-    cb: (state: State, value: Value) => any
+    cb: (value: Value, state: State) => any
   ): InitialValue extends undefined
     ? NoValueAction<State, Context, InitialValue, Value>
     : Action<State, Context, InitialValue, Value>
@@ -99,10 +99,10 @@ export default function createActionFactory<State, Context>(proxyStateTree) {
         runOperators
       ) as any,
       {
-        mutation(cb: (state: State, value: Value) => any) {
+        mutation(cb: (value: Value, state: State) => any) {
           const operator = (value, context) => {
             proxyStateTree.startMutationTracking()
-            cb(context.state, value)
+            cb(value, context.state)
             const mutations = proxyStateTree.clearMutationTracking()
             actionChain.emit('mutations', {
               mutations,

packages/node_modules/overmind/src/index.test.ts

@@ -54,7 +54,7 @@ describe('OPERATORS', () => {
         foo: 'bar',
       },
       actions: (action) => ({
-        doThis: action().mutation((state) => (state.foo = 'bar2')),
+        doThis: action().mutation((_, state) => (state.foo = 'bar2')),
       }),
     })