Skip to content

Commit 4ed9eec

Browse files
fix(overmind): fix effects for namespaces and remove views
1 parent 8b9beab commit 4ed9eec

File tree

7 files changed

+14
-316
lines changed

7 files changed

+14
-316
lines changed

packages/node_modules/overmind/jest.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
module.exports = {
22
collectCoverage: true,
3+
testURL: 'http://localhost/',
34
collectCoverageFrom: ['src/**/*.{t,j}s?(x)', '!src/**/*.d.ts'],
45
moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json'],
56
transform: {

packages/node_modules/overmind/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,12 @@
4848
"@types/jest": "^23.1.4",
4949
"@types/react": "^16.4.6",
5050
"jest": "^23.3.0",
51+
"jsdom": "^11.12.0",
5152
"react": "^16.4.1",
5253
"react-test-renderer": "^16.4.1",
5354
"rimraf": "^2.6.2",
5455
"ts-jest": "^23.0.0",
55-
"typescript": "^2.9.2"
56+
"typescript": "^2.9.2",
57+
"vue": "^2.5.16"
5658
}
5759
}

packages/node_modules/overmind/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,9 +271,9 @@ export default class App<
271271
data,
272272
})
273273
)
274-
actionChain.on('provider', (data) =>
274+
actionChain.on('effect', (data) =>
275275
devtools.send({
276-
type: 'provider',
276+
type: 'effect',
277277
data,
278278
})
279279
)

packages/node_modules/overmind/src/namespaces.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ export type Namespace = 'namespace'
22

33
type Module = {
44
state?: any
5-
providers?: any
5+
effects?: any
66
actions?: any
77
reactions?: any
88
}
@@ -23,11 +23,11 @@ export default function namespaces<Namespaces extends TNamespaces>(
2323
? Namespaces[Namespace]['state']
2424
: any
2525
}
26-
providers: {
26+
effects: {
2727
[Namespace in keyof Namespaces]: Namespaces[Namespace] extends ModuleFunction
28-
? ReturnType<Namespaces[Namespace]>['providers']
28+
? ReturnType<Namespaces[Namespace]>['effects']
2929
: Namespaces[Namespace] extends Module
30-
? Namespaces[Namespace]['providers']
30+
? Namespaces[Namespace]['effects']
3131
: any
3232
}
3333
actions: {
@@ -57,9 +57,9 @@ export default function namespaces<Namespaces extends TNamespaces>(
5757
...aggr.state,
5858
[key]: namespace.state || {},
5959
},
60-
providers: {
61-
...aggr.providers,
62-
[key]: namespace.providers || {},
60+
effects: {
61+
...aggr.effects,
62+
[key]: namespace.effects || {},
6363
},
6464
actions: {
6565
...aggr.actions,
@@ -73,7 +73,7 @@ export default function namespaces<Namespaces extends TNamespaces>(
7373
},
7474
{
7575
state: {},
76-
providers: {},
76+
effects: {},
7777
actions: {},
7878
reactions: {},
7979
}

packages/node_modules/overmind/src/views/__snapshots__/react.test.tsx.snap

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/node_modules/overmind/src/views/react.test.tsx

Lines changed: 0 additions & 99 deletions
This file was deleted.

packages/node_modules/overmind/src/views/react.ts

Lines changed: 0 additions & 193 deletions
This file was deleted.

0 commit comments

Comments
 (0)