feat(overmind): operator factories, error operators and removed value deprecation

BREAKING CHANGE:
removed value and deprecation from context

Author: christianalfoni

packages/node_modules/overmind-devtools/src/components/Action/index.tsx

@@ -24,39 +24,42 @@ const Action: SFC = () => {
       >
         expand all
       </div>
-      {state.currentAction.operators.map((operator, index) => {
-        const prevOperator = state.currentAction.operators[index - 1]
-        const value =
-          index === 0 ? state.currentAction.value : prevOperator.result
-        const flushReference =
-          state.currentApp.flushByOperatorId[getOperatorId(operator)]
-        const flush =
-          flushReference && state.currentApp.flushes[flushReference.flushId]
+      {Object.keys(state.currentAction.operators)
+        .sort()
+        .map((operatorId, index) => {
+          const operator = state.currentAction.operators[operatorId]
+          const prevOperator = state.currentAction.operators[index - 1]
+          const value =
+            index === 0 ? state.currentAction.value : prevOperator.result
+          const flushReference =
+            state.currentApp.flushByOperatorId[getOperatorId(operator)]
+          const flush =
+            flushReference && state.currentApp.flushes[flushReference.flushId]
+
+          if (flush) {
+            return (
+              <div key={operator.actionId + '_' + operator.operatorId}>
+                <ActionOperator
+                  prevOperator={prevOperator}
+                  operator={operator}
+                  value={value}
+                  operatorIndex={index}
+                />
+                <Flush flush={flush} />
+              </div>
+            )
+          }
 
-        if (flush) {
           return (
-            <div key={operator.actionId + '_' + operator.operatorId}>
-              <ActionOperator
-                prevOperator={prevOperator}
-                operator={operator}
-                value={value}
-                operatorIndex={index}
-              />
-              <Flush flush={flush} />
-            </div>
+            <ActionOperator
+              key={operator.actionId + '_' + operator.operatorId}
+              prevOperator={prevOperator}
+              operator={operator}
+              value={value}
+              operatorIndex={index}
+            />
           )
-        }
-
-        return (
-          <ActionOperator
-            key={operator.actionId + '_' + operator.operatorId}
-            prevOperator={prevOperator}
-            operator={operator}
-            value={value}
-            operatorIndex={index}
-          />
-        )
-      })}
+        })}
       {!state.currentAction.isRunning && flush ? <Flush flush={flush} /> : null}
     </div>
   )

packages/node_modules/overmind-devtools/src/overmind/operators.ts

@@ -187,7 +187,7 @@ export const addAction: Operator<StartActionMessage> = action(
     app.actions[actionId] = {
       ...action,
       isRunning: true,
-      operators: [],
+      operators: {},
       hasError: false,
     }
 
@@ -232,26 +232,7 @@ export const addOperator: Operator<StartOperatorMessage> = action(
       events: [],
     }
 
-    action.operators.push(operator)
-
-    /*
-    This ensures the order of operators, as actions composed with
-    "parallel" operator can trigger operators sync/async, adding
-    them in wrong order
-  */
-    const paths = new Map()
-    action.operators.forEach((operator, index) => {
-      const path = operator.path.length ? operator.path.join('.') : '__' + index
-      if (paths.has(path)) {
-        paths.get(path).push(operator)
-      } else {
-        paths.set(path, [operator])
-      }
-    })
-    action.operators = Array.from(paths).reduce(
-      (aggr, arr) => aggr.concat(arr[1]),
-      []
-    )
+    action.operators[operator.operatorId] = operator
   }
 )
 
@@ -260,9 +241,7 @@ export const updateOperator: Operator<EndOperatorMessage> = action(
     const operatorData = message.data
     const actionId = getActionId(operatorData)
     const action = state.apps[message.appName].actions[actionId]
-    const operator = action.operators.find(
-      (operator) => getOperatorId(operatorData) === getOperatorId(operator)
-    )
+    const operator = action.operators[getOperatorId(operatorData)]
 
     operator.isAsync = operatorData.isAsync
     operator.isRunning = false

packages/node_modules/overmind-devtools/src/overmind/types.ts

@@ -75,7 +75,9 @@ export type Action = {
   actionId: number
   executionId: number
   isRunning: boolean
-  operators: Operator[]
+  operators: {
+    [id: string]: Operator
+  }
   value: any
   hasError: boolean
 }