fix(overmind): fix general error handling issues

Author: christianalfoni

packages/node_modules/overmind/src/index.ts

@@ -586,7 +586,8 @@ export class Overmind<ThisConfig extends IConfiguration>
           isPending: true,
           error: false,
         })
-        result
+
+        return result
           .then((promisedResult) => {
             // eslint-disable-next-line standard/no-callback-literal
             this.eventHub.emit(EventType.EFFECT, {
@@ -597,6 +598,8 @@ export class Overmind<ThisConfig extends IConfiguration>
               isPending: false,
               error: false,
             })
+
+            return promisedResult
           })
           .catch((error) => {
             this.eventHub.emit(EventType.EFFECT, {
@@ -608,18 +611,18 @@ export class Overmind<ThisConfig extends IConfiguration>
             })
             throw error
           })
-      } else {
-        // eslint-disable-next-line standard/no-callback-literal
-        this.eventHub.emit(EventType.EFFECT, {
-          ...execution,
-          ...effect,
-          args: safeValues(effect.args),
-          result: safeValue(result),
-          isPending: false,
-          error: false,
-        })
       }
 
+      // eslint-disable-next-line standard/no-callback-literal
+      this.eventHub.emit(EventType.EFFECT, {
+        ...execution,
+        ...effect,
+        args: safeValues(effect.args),
+        result: safeValue(result),
+        isPending: false,
+        error: false,
+      })
+
       return result
     })
   }
@@ -830,33 +833,28 @@ export function pipe(...operators) {
       const run = (operatorErr, operatorContext) => {
         const operator = operators[operatorIndex++]
 
-        if (!operator) return next(operatorErr, operatorContext)
-
-        if (operatorErr)
-          return operator(operatorErr, operatorContext, run, final)
-
         if (operatorContext.value instanceof Promise) {
           context.execution.emit(EventType.OPERATOR_ASYNC, {
             ...operatorContext.execution,
             isAsync: true,
           })
           operatorContext.value
             .then((promiseValue) =>
-              operator(
+              (operator || next)(
                 null,
                 { ...operatorContext, value: promiseValue },
                 run,
                 final
               )
             )
             .catch((promiseError) =>
-              operator(promiseError, operatorContext, run, final)
+              (operator || next)(promiseError, operatorContext, run, final)
             )
         } else {
           try {
-            operator(null, operatorContext, run, final)
+            ;(operator || next)(operatorErr, operatorContext, run, final)
           } catch (operatorError) {
-            operator(operatorError, operatorContext, run, final)
+            ;(operator || next)(operatorError, operatorContext, run, final)
           }
         }
       }