feat(overmind): remove reactions

BREAKING CHANGE:
reactions are removed

Author: christianalfoni

packages/node_modules/overmind-angular/src/index.ts

@@ -7,11 +7,6 @@ export type TConnect<Config extends Configuration> = {
   overmind: {
     state: TApp<Config>['state']
     actions: TApp<Config>['actions']
-    reaction: (
-      name: string,
-      stateCb: (state: TApp<Config>['state']) => any,
-      Function
-    ) => void
   }
 }
 
@@ -27,15 +22,11 @@ export const createConnect = <A extends Overmind<any>>(overmind: A) => () => {
     const targetNgAfterContentInit = target.prototype.ngAfterContentInit
     const targetNgAfterViewInit = target.prototype.ngAfterViewInit
     const targetNgAfterViewChecked = target.prototype.ngAfterViewChecked
-    const reactionFactory = overmind.createReactionFactory(
-      target.constructor.name
-    )
 
     target.prototype.ngOnInit = function() {
       this.overmind = {
         state: overmind.state,
         actions: overmind.actions,
-        reaction: reactionFactory.add,
       }
       this.__componentInstanceId = componentInstanceId++
       this.__shouldUpdatePaths = false
@@ -133,7 +124,6 @@ export const createConnect = <A extends Overmind<any>>(overmind: A) => () => {
         name: this.constructor.name || '',
       })
       this.__listener.dispose()
-      this.__reactionFactory.dispose()
     }
 
     return target

packages/node_modules/overmind-react/src/index.test.tsx

@@ -117,58 +117,6 @@ describe('React', () => {
     expect(tree2).toMatchSnapshot()
   })
 
-  test('should connect reactions to components', () => {
-    expect.assertions(2)
-    let reactionCount = 0
-    const doThis: Action = ({ state }) => (state.foo = 'bar2')
-
-    const config = {
-      state: {
-        foo: 'bar',
-      },
-      actions: {
-        doThis,
-      },
-    }
-    type IConfig = {
-      state: {
-        foo: typeof config.state.foo
-      }
-      actions: {
-        doThis: typeof doThis
-      }
-    }
-
-    const app = new Overmind(config)
-
-    type Action<Input = void> = TAction<IConfig, Input>
-
-    const connect = createConnect(app)
-
-    class Component extends React.Component<TConnect<IConfig>> {
-      componentDidMount() {
-        this.props.overmind.reaction(
-          'my-reaction',
-          (state) => state.foo,
-          () => {
-            reactionCount++
-          }
-        )
-      }
-      render() {
-        const { overmind } = this.props
-        return <h1>{overmind.state.foo}</h1>
-      }
-    }
-    const ConnectedComponent = connect(Component)
-    const instance = renderer.create(<ConnectedComponent />)
-    app.actions.doThis()
-    expect(reactionCount).toBe(1)
-    instance.unmount()
-    app.actions.doThis()
-    expect(reactionCount).toBe(1)
-  })
-
   test('should preserve component name', () => {
     const app = new Overmind({})
     const connect = createConnect(app)

packages/node_modules/overmind-react/src/index.ts

@@ -29,11 +29,6 @@ export type TConnect<Config extends Configuration> = {
   overmind: {
     state: TApp<Config>['state']
     actions: TApp<Config>['actions']
-    reaction: (
-      name: string,
-      stateCb: (state: TApp<Config>['state']) => any,
-      Function
-    ) => void
   }
 }
 
@@ -194,9 +189,6 @@ export const createConnect = <A extends Overmind<Configuration>>(
       __isUnmounting: boolean
       __componentId: number
       __componentInstanceId = componentInstanceId++
-      __reactionFactory = overmind.createReactionFactory(
-        Component.name || Component.displayName || 'Component'
-      )
       componentWillUnmount() {
         this.__isUnmounting = true
         if (this.__mutationListener) {
@@ -207,7 +199,6 @@ export const createConnect = <A extends Overmind<Configuration>>(
           })
           this.__mutationListener.dispose()
         }
-        this.__reactionFactory.dispose()
       }
       renderStatelessComponent() {
         const trackId = overmind.trackState()
@@ -216,7 +207,6 @@ export const createConnect = <A extends Overmind<Configuration>>(
             overmind: {
               state: overmind.state,
               actions: overmind.actions,
-              reaction: this.__reactionFactory.add,
               __componentInstanceId: this.__componentInstanceId,
             },
           }),
@@ -264,7 +254,6 @@ export const createConnect = <A extends Overmind<Configuration>>(
           overmind: {
             state: overmind.state,
             actions: overmind.actions,
-            reaction: this.__reactionFactory.add,
             __componentInstanceId: this.__componentInstanceId,
           },
         }) as any)

packages/node_modules/overmind-vue/src/Index.test.ts

@@ -43,35 +43,4 @@ describe('Vue', () => {
       done()
     })
   })
-  it('should expose reaction', (done) => {
-    expect.assertions(1)
-    let hasReacted = false
-    const app = new Overmind({
-      state: {
-        foo: 'bar',
-      },
-      actions: {
-        changeFoo: ({ state }) => (state.foo = 'bar2'),
-      },
-    })
-    const connect = createConnect(app)
-    const instance = new Vue(
-      connect({
-        el: dom.window.document.createElement('div'),
-        mounted() {
-          this.overmind.reaction(
-            (state) => state.foo,
-            () => {
-              hasReacted = true
-            }
-          )
-        },
-      })
-    )
-    Vue.nextTick(() => {
-      instance.overmind.actions.changeFoo()
-      expect(hasReacted).toBe(true)
-      done()
-    })
-  })
 })

packages/node_modules/overmind-vue/src/index.ts

@@ -5,11 +5,6 @@ export type TConnect<Config extends Configuration> = {
   overmind: {
     state: TApp<Config>['state']
     actions: TApp<Config>['actions']
-    reaction: (
-      name: string,
-      stateCb: (state: TApp<Config>['state']) => any,
-      Function
-    ) => void
   }
 }
 
@@ -48,14 +43,10 @@ export const createConnect = <A extends Overmind<any>>(overmind: A) => <
   // the state to the component as "store",
   // allowing templates to access it
   componentOptions.beforeMount = function() {
-    this.__reactionFactory = overmind.createReactionFactory(
-      this.name || this.displayName
-    )
     this.__componentInstanceId = componentInstanceId++
     this.overmind = {
       state: overmind.state,
       actions: overmind.actions,
-      reaction: this.__reactionFactory.add,
     }
     this.__trackId = overmind.trackState()
     beforeMount && beforeMount.call(this)
@@ -115,7 +106,6 @@ export const createConnect = <A extends Overmind<any>>(overmind: A) => <
     })
 
     this.__proxyStateTreeListener && this.__proxyStateTreeListener.dispose()
-    this.__reactionFactory && this.__reactionFactory.dispose()
     beforeDestroy && beforeDestroy.call(this)
   }
 

packages/node_modules/overmind/src/index.ts

@@ -10,7 +10,6 @@ import {
   ResolveState,
 } from './internalTypes'
 import { proxifyEffects } from './proxyfyEffects'
-import { Reaction } from './reaction'
 import {
   Configuration,
   TAction,
@@ -377,13 +376,6 @@ export class Overmind<Config extends Configuration> implements Configuration {
       },
       {}
     )
-    Object.keys(reactions).forEach((name) => {
-      const reaction = new Reaction(eventHub, proxyStateTree, name)
-      reaction.create(
-        reactions[name][0],
-        this.createAction(name, reactions[name][1])
-      )
-    })
   }
   private getState(configuration: Configuration) {
     let state = {}
@@ -469,30 +461,6 @@ export class Overmind<Config extends Configuration> implements Configuration {
   addMutationListener(cb) {
     return this.proxyStateTree.addMutationListener(cb)
   }
-  createReactionFactory(prefix: string) {
-    const reactions: Reaction[] = []
-    const instance = this
-    return {
-      add(
-        name: string,
-        stateCb: (state: ResolveState<Config['state']>) => any,
-        cb: Function
-      ) {
-        const reaction = new Reaction(
-          instance.eventHub,
-          instance.proxyStateTree,
-          prefix + '.' + name
-        )
-        reaction.create(stateCb, cb)
-
-        reactions.push(reaction)
-      },
-      dispose() {
-        reactions.forEach((reaction) => reaction.destroy())
-        reactions.length = 0
-      },
-    }
-  }
 }
 
 /*

packages/node_modules/overmind/src/reaction.test.ts

@@ -2,7 +2,7 @@
 
 The base configuration of your application is:
 
-`{ state, actions, effects, reactions }`
+`{ state, actions, effects }`
 
 When your application grows it will be necessary to split up your configuration. Overmind provides some helpers allowing you to structure and scale up your configuration.