fix(overmind): add strictNullChecks and fix code with this setting

Author: gaspard

package-lock.json

@@ -79,17 +79,17 @@
     "jsdom": "11.12.0",
     "lint-staged": "^7.2.0",
     "parcel-bundler": "1.9.7",
-    "prettier": "1.13.7",
+    "prettier": "1.15.2",
     "raw-loader": "0.5.1",
     "react-test-renderer": "16.4.1",
     "repo-cooker": "^6.2.7",
     "rimraf": "2.6.2",
     "source-map-loader": "0.2.4",
-    "ts-jest": "23.0.0",
+    "ts-jest": "23.10.4",
     "ts-loader": "4.4.2",
     "tslib": "1.9.3",
-    "typescript": "2.9.2",
-    "typescript-eslint-parser": "^18.0.0",
+    "typescript": "3.1.3",
+    "typescript-eslint-parser": "^21.0.1",
     "url-loader": "1.0.1",
     "vue": "2.5.16",
     "vue-template-compiler": "2.5.16",

package.json

@@ -19,7 +19,8 @@ export class ActionChain<Effects, ExtraEvents = {}> extends EventEmitter<
       return proxifyEffects(
         this.effects,
         this.options.providerExceptions,
-        (effect) => this.emitAsync('effect', { ...thisExecution, ...effect })
+        (effect) =>
+          this.emitAsync('effect', { ...thisExecution, ...effect } as any)
       )
     }
 

packages/node_modules/action-chain/src/ActionChain.ts

@@ -111,7 +111,7 @@ describe('React', () => {
     }
     const ConnectedComponent = connect(Component)
     const tree = renderer.create(<ConnectedComponent />).toJSON()
-    const tree2 = renderer.create(<Component app={null} />).toJSON()
+    const tree2 = renderer.create(<Component app={null as any} />).toJSON()
 
     expect(tree).toMatchSnapshot()
     expect(tree2).toMatchSnapshot()

packages/node_modules/overmind-react/src/index.test.tsx

@@ -1,18 +1,22 @@
-import { BaseApp, EventType, Overmind, Configuration } from 'overmind'
-import * as React from 'react'
+import { BaseApp, Configuration, EventType, Overmind } from 'overmind'
 import {
+  // @ts-ignore
+  __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED,
+  ClassicComponentClass,
+  ComponentClass,
+  createElement,
+  PureComponent,
+  StatelessComponent,
   // @ts-ignore
   useEffect,
   // @ts-ignore
   useState,
-  // @ts-ignore
-  __SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED,
 } from 'react'
 
 export type IReactComponent<P = any> =
-  | React.StatelessComponent<P>
-  | React.ComponentClass<P>
-  | React.ClassicComponentClass<P>
+  | StatelessComponent<P>
+  | ComponentClass<P>
+  | ClassicComponentClass<P>
 
 // Diff / Omit taken from https://github.com/Microsoft/TypeScript/issues/12215#issuecomment-311923766
 type Omit<T, K extends keyof T> = Pick<
@@ -182,15 +186,15 @@ export const createConnect = <App extends Overmind<Configuration>>(
       }
     }
 
-    const klass = class extends React.PureComponent<
+    const klass = class extends PureComponent<
       Omit<Props & TConnect<App>, keyof TConnect<App>>
     > {
       __mutationListener: any
       __isUnmounting: boolean
       __componentId: number
       __componentInstanceId = componentInstanceId++
       __reactionFactory = app.createReactionFactory(
-        Component.name || Component.displayName
+        Component.name || Component.displayName || 'Component'
       )
       componentWillUnmount() {
         this.__isUnmounting = true
@@ -255,7 +259,7 @@ export const createConnect = <App extends Overmind<Configuration>>(
         return value
       }
       renderClassComponent() {
-        return React.createElement(Component, Object.assign({}, this.props, {
+        return createElement(Component, Object.assign({}, this.props, {
           app: {
             state: app.state,
             actions: app.actions,

packages/node_modules/overmind-react/src/index.ts

@@ -8,6 +8,7 @@
     "newLine": "LF",
     "lib": ["dom", "es2017"],
     "moduleResolution": "node",
+    "strictNullChecks": true,
     "importHelpers": true,
     "declaration": true,
     "pretty": true,

packages/node_modules/overmind-react/tsconfig.json

@@ -48,7 +48,7 @@ function debounce(func, wait) {
 
 export class Devtools {
   private buffer: string[] = []
-  private ws: WebSocket = null
+  private ws: WebSocket
   private isConnected: boolean = false
   private doReconnect: boolean = false
   private hasWarnedReconnect: boolean = false

packages/node_modules/overmind/src/Devtools.ts

@@ -287,7 +287,7 @@ describe('Overmind', () => {
     expect(typeof app.actions.bar.bar).toBe('function')
   })
   test('should instantiate modules with onInitialize', () => {
-    const result = []
+    const result: string[] = []
     const app = new Overmind(
       modules({
         foo: {

packages/node_modules/overmind/src/index.test.ts

@@ -62,7 +62,7 @@ export class Overmind<Config extends Configuration> implements BaseApp {
   initialized: Promise<any>
   eventHub: EventEmitter<Events>
   devtools: Devtools
-  actions: ResolveActions<Config['actions']>
+  actions: ResolveActions<Config['actions'] & {}>
   state: ResolveState<Config['state'] & {}>
   effects: Config['effects'] & {}
   constructor(configuration: Config, options: Options = {}) {
@@ -224,7 +224,6 @@ export class Overmind<Config extends Configuration> implements BaseApp {
         this.eventHub.emit(EventType.OPERATOR_START, {
           ...execution,
           operatorId: 0,
-          name: undefined,
           type: 'action',
         })
         const scopedTree = this.proxyStateTree.getScopedTree()
@@ -439,7 +438,7 @@ export class Overmind<Config extends Configuration> implements BaseApp {
     return this.proxyStateTree.addFlushListener(paths, cb)
   }
   createReactionFactory(prefix: string) {
-    const reactions = []
+    const reactions: Reaction[] = []
     const instance = this
     return {
       add(

packages/node_modules/overmind/src/index.ts

@@ -46,7 +46,7 @@ export interface Events {
   [EventType.OPERATOR_START]: Execution & {
     path: string[]
     type: string
-    name: string
+    name?: string
   }
   [EventType.OPERATOR_END]: Execution & {
     path: string[]
@@ -119,8 +119,10 @@ export type ResolveState<State extends object> = {
   [P in keyof State]: State[P] extends TDerive<any, any>
     ? ReturnType<State[P]>
     : State[P] extends Array<any>
-      ? State[P]
-      : State[P] extends object ? ResolveState<State[P]> : State[P]
+    ? State[P]
+    : State[P] extends object
+    ? ResolveState<State[P]>
+    : State[P]
 }
 
 type TActionValue<T> = T extends (a1: infer TContext) => any
@@ -147,10 +149,10 @@ export type ResolveActions<Actions extends NestedActions> = {
       ? () => Promise<ReturnType<Actions[T]>>
       : (value: TActionValue<Actions[T]>) => Promise<ReturnType<Actions[T]>>
     : Actions[T] extends TOperator<any, any>
-      ? [TOperationValue<Actions[T]>] extends [void]
-        ? () => Promise<ReturnType<Actions[T]>>
-        : (
-            value: TOperationValue<Actions[T]>
-          ) => Promise<ReturnType<Actions[T]>>
-      : Actions[T] extends NestedActions ? ResolveActions<Actions[T]> : never
+    ? [TOperationValue<Actions[T]>] extends [void]
+      ? () => Promise<ReturnType<Actions[T]>>
+      : (value: TOperationValue<Actions[T]>) => Promise<ReturnType<Actions[T]>>
+    : Actions[T] extends NestedActions
+    ? ResolveActions<Actions[T]>
+    : never
 }