Merge pull request cerebral#94 from cerebral/stringifyNestedSafely

christianalfoni · web-flow · commit 27f7c16987d7 · 2018-09-23T17:11:56.000+02:00
fix(overmind): stringify nested values safely
diff --git a/packages/node_modules/overmind/src/Devtools.ts b/packages/node_modules/overmind/src/Devtools.ts
@@ -16,7 +16,13 @@ export function safeValue(value) {
     return `[${value.constructor.name || 'NOT SERIALIZABLE'}]`
   }
 
-  return value
+  return isPlainObject(value)
+    ? Object.keys(value).reduce((aggr, key) => {
+        aggr[key] = safeValue(value[key])
+
+        return aggr
+      }, value)
+    : value
 }
 
 export function safeValues(values) {

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,13 @@ export function safeValue(value) {`
`16`	`16`	return `[${value.constructor.name \|\| 'NOT SERIALIZABLE'}]`
`17`	`17`	`}`
`18`	`18`
`19`		`- return value`
	`19`	`+ return isPlainObject(value)`
	`20`	`+ ? Object.keys(value).reduce((aggr, key) => {`
	`21`	`+ aggr[key] = safeValue(value[key])`
	`22`	`+`
	`23`	`+ return aggr`
	`24`	`+ }, value)`
	`25`	`+ : value`
`20`	`26`	`}`
`21`	`27`
`22`	`28`	`export function safeValues(values) {`