fix(overmind): make mutation values stringify safe

Author: christianalfoni

packages/node_modules/overmind-devtools/src/app/state.ts

@@ -42,7 +42,7 @@ const state: State = {
   newPortValue: '',
   currentTab: Tab.State,
   expandedStatePaths: [''],
-  expandAllActionDetails: false,
+  expandAllActionDetails: true,
   expandedComponents: [],
   currentApp: (state) => state.apps[state.currentAppName],
   componentsMounted: (state) =>

packages/node_modules/overmind-devtools/src/components/ActionOperator/index.tsx

@@ -25,7 +25,6 @@ const ActionOperator: SFC<Props> = ({
   const { state, actions } = useOvermind()
   const isExpanded = state.expandAllActionDetails || !operator.isCollapsed
 
-  console.log(operator.mutations)
   return (
     <div>
       {value === undefined ? null : (

packages/node_modules/overmind/src/index.ts

@@ -1,7 +1,7 @@
 import { EventEmitter } from 'betsy'
-import { IS_PROXY, ProxyStateTree, TTree } from 'proxy-state-tree'
+import { IS_PROXY, ProxyStateTree, TTree, IMutation } from 'proxy-state-tree'
 import { Derived } from './derived'
-import { Devtools, Message, safeValue } from './Devtools'
+import { Devtools, Message, safeValue, safeValues } from './Devtools'
 import {
   Events,
   EventType,
@@ -46,8 +46,12 @@ const IS_PRODUCTION = process.env.NODE_ENV === 'production'
 const IS_DEVELOPMENT = process.env.NODE_ENV === 'development'
 const IS_OPERATOR = Symbol('operator')
 
-export const log = (...objects: any[]) =>
-  console.log(...objects.map((obj) => JSON.parse(JSON.stringify(obj))))
+export const makeStringifySafeMutations = (mutations: IMutation[]) => {
+  return mutations.map((mutation) => ({
+    ...mutation,
+    args: safeValues(mutation.args),
+  }))
+}
 
 const hotReloadingCache = {}
 
@@ -123,6 +127,7 @@ export class Overmind<Config extends Configuration> implements Configuration {
           data: {
             ...data,
             ...flushData,
+            mutations: makeStringifySafeMutations(flushData.mutations),
           },
         })
       }
@@ -135,6 +140,7 @@ export class Overmind<Config extends Configuration> implements Configuration {
           data: {
             ...data,
             ...flushData,
+            mutations: makeStringifySafeMutations(flushData.mutations),
           },
         })
       }
@@ -247,7 +253,7 @@ export class Overmind<Config extends Configuration> implements Configuration {
         mutationTree.onMutation((mutation) => {
           this.eventHub.emit(EventType.MUTATIONS, {
             ...execution,
-            mutations: [mutation],
+            mutations: makeStringifySafeMutations([mutation]),
           })
           setTimeout(() => {
             const flushData = this.proxyStateTree.flush(true)
@@ -257,6 +263,7 @@ export class Overmind<Config extends Configuration> implements Configuration {
                 data: {
                   ...execution,
                   ...flushData,
+                  mutations: makeStringifySafeMutations(flushData.mutations),
                 },
               })
             }
@@ -749,7 +756,7 @@ export function mutate<Input, Config extends Configuration = TheConfig>(
           context.execution.emit(EventType.MUTATIONS, {
             ...context.execution,
             operatorId: context.execution.operatorId + 1,
-            mutations: [mutation],
+            mutations: makeStringifySafeMutations([mutation]),
           })
         })
       }